soft_purge doesn't actually issue soft header - it's a hard purge

[mrthan]

Same code as #61. Running fastly-rails#0.7.1 using httplog to watch requests.

I don't see any Fastly-Soft-Purge:1 header being sent with the request as the docs indicate. It looks like fastly-rails/client.rb is keeping it too simple and not deferring the the fastly api gem to do this correctly.

after_save :soft_purge results in

DEBUG -- : [httplog] Sending: POST http://api.fastly.com:443/service/ABC123/purge/mykey/123
DEBUG -- : [httplog] Data: 
DEBUG -- : [httplog] Status: 200
DEBUG -- : [httplog] Benchmark: 0.12983361499937018 seconds
DEBUG -- : [httplog] Response: {"status": "ok", "id": "577-xxxx-32"}

From the docs I'm expecting to see a PURGE request and a header sent

[thommahoney]

@mrthan I don't see any request headers being logged in your paste above.

fastly-rails#0.7.1 uses fastly-ruby#1.6.0 which supports soft purging by accepting an optional argument in the purge_by_key method. This method is defined here: https://github.com/fastly/fastly-ruby/blob/de9ec93d1cb8444b0fa3e6ae344de96cd429ff24/lib/fastly/service.rb#L72

When the soft argument is true, we append the Fastly-Soft-Purge header to the API request.

We call Fastly::Service#purge_by_key here:

fastly-rails/lib/fastly-rails/client.rb

Line 12 in 306dfc8

Fastly::Service.new({id: FastlyRails.service_id}, FastlyRails.client).purge_by_key(*args)

which is called by the soft_purge method here:

fastly-rails/lib/fastly-rails/active_record/surrogate_key.rb

Line 41 in 8245aa8

FastlyRails.purge_by_key(record_key, true)

(note the true argument)

Could I have you confirm that the Fastly-Soft-Purge header is indeed not being sent?