Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BIGML_DOMAIN for returned URLs #18

Open
fwallacevt opened this issue May 8, 2020 · 4 comments
Open

Use BIGML_DOMAIN for returned URLs #18

fwallacevt opened this issue May 8, 2020 · 4 comments

Comments

@fwallacevt
Copy link
Contributor

bigml-parallel doesn’t use BIGML_DOMAIN for resource URLs it returns. E.g., even if an ensemble is built on the VPC with BIGML_DOMAIN domain.path.io, it returns a url https://bigml.com/dashboard/ensemble/xxx

@fwallacevt
Copy link
Contributor Author

@emk could these be the culprits:

#[fail(display = "https://bigml.com/dashboard/{} failed ({})", id, message)]
,
pub fn dashboard_url(&self) -> Url {
Url::parse(&format!("https://bigml.com/dashboard/{}", self))
// This should never fail to parse.
.expect("dashboard URL unexpectedly failed to parse")
}

@seamusabshere
Copy link
Member

proposed fix here: #19

@emk
Copy link
Collaborator

emk commented May 17, 2020

@fwallacevt @seamusabshere Neither of these is causing the problem with bigml-parallel output. The problem with bigml-parallel output is on BigML's end, because we just pass the resource data from BigML straight through.

@seamusabshere seamusabshere reopened this May 17, 2020
@seamusabshere
Copy link
Member

still - BIGML_DOMAIN should be respected (low priority)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants