-
-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we have APIException inherit from ZenpyException? #521
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It'd be nice if there was one singular exception which we could catch to handle all forms of exceptions from Zenpy. Every exception in
lib.exception
inherits fromZenpyException
except forAPIException
which inherits directly fromException
. I think anyone catchingZenpyException
would probably want it to catchAPIException
as well.If you agree, I'd be happy to make a PR to implement it. I've been using the library a lot so I'd like to contribute back and help improve it. This seems like a good first PR!
The text was updated successfully, but these errors were encountered: