Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about random_sized_crop confused ? #123

Open
ranjiewwen opened this issue Dec 3, 2020 · 1 comment
Open

about random_sized_crop confused ? #123

ranjiewwen opened this issue Dec 3, 2020 · 1 comment

Comments

@ranjiewwen
Copy link

ranjiewwen commented Dec 3, 2020

i my codebase to train regnetx_200m, i use this function 'random_sized_crop' in transform, while get bad result, train acc get 90%+, while val acc get 50%+
random_sized_crop(image, size=cfg.data.image_size, area_frac=0.08)

when i use torchvision method , training result is normal.

 image = PIL.Image.fromarray(image)
 image = torchvision.transforms.RandomResizedCrop(cfg.data.image_size)(image)
 image = np.array(image)

anyone meet this problem ? i see the source code diff below, i think this shouldn't make so big different.

         # torchvision
        target_area = random.uniform(*scale) * area
        log_ratio = (math.log(ratio[0]), math.log(ratio[1]))
        aspect_ratio = math.exp(random.uniform(*log_ratio))
        # pycls
        target_area = np.random.uniform(area_frac, 1.0) * area
        aspect_ratio = np.random.uniform(3.0 / 4.0, 4.0 / 3.0)
@ranjiewwen
Copy link
Author

when change the code in pycls/datasets/transforms.py , functions: random_sized_crop use torchvision aspect_ratio, training result is right !!! so different result from there ???

 target_area = random.uniform(*(area_frac, 1.0)) * area
 log_ratio = (math.log(3.0 / 4.0), math.log(4.0 / 3.0))
 aspect_ratio = math.exp(random.uniform(*log_ratio))
 # target_area = np.random.uniform(area_frac, 1.0) * area
 # aspect_ratio = np.random.uniform(3.0 / 4.0, 4.0 / 3.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant