Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_loss_fun err message #117

Open
flystarhe opened this issue Oct 21, 2020 · 2 comments
Open

get_loss_fun err message #117

flystarhe opened this issue Oct 21, 2020 · 2 comments

Comments

@flystarhe
Copy link
Contributor

assert cfg.MODEL.LOSS_FUN in _loss_funs.keys(), err_str.format(cfg.TRAIN.LOSS)

assert cfg.MODEL.LOSS_FUN in _loss_funs.keys(), err_str.format(cfg.TRAIN.LOSS)

To:

assert cfg.MODEL.LOSS_FUN in _loss_funs.keys(), err_str.format(cfg.MODEL.LOSS)
@flystarhe
Copy link
Contributor Author

assert cfg.MODEL.LOSS_FUN in _loss_funs.keys(), err_str.format(cfg.MODEL.LOSS_FUN)

@pdollar
Copy link
Member

pdollar commented Dec 2, 2020

Sorry just getting to this now. Nice catch! Interestingly, this bug has existed since our very first release of pycls.

@flystarhe do you want to create a PR? Otherwise, I'll fix this on my side soon.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants