From 5ae73de1d15d49325581b857184410415c2ce8a5 Mon Sep 17 00:00:00 2001 From: Chernoev Andrew Date: Fri, 13 Jul 2018 21:00:56 +0700 Subject: [PATCH 1/3] Set build current version and lib version --- SocketRocket.xcodeproj/project.pbxproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SocketRocket.xcodeproj/project.pbxproj b/SocketRocket.xcodeproj/project.pbxproj index 30aa8a4a1..57e19f2d6 100644 --- a/SocketRocket.xcodeproj/project.pbxproj +++ b/SocketRocket.xcodeproj/project.pbxproj @@ -1207,6 +1207,8 @@ isa = XCBuildConfiguration; baseConfigurationReference = 81D6475A1D2CA6A100690609 /* SocketRocket-iOS.xcconfig */; buildSettings = { + CURRENT_PROJECT_VERSION = 1.0; + DYLIB_CURRENT_VERSION = 1.0; }; name = Debug; }; @@ -1214,6 +1216,8 @@ isa = XCBuildConfiguration; baseConfigurationReference = 81D6475A1D2CA6A100690609 /* SocketRocket-iOS.xcconfig */; buildSettings = { + CURRENT_PROJECT_VERSION = 1.0; + DYLIB_CURRENT_VERSION = 1.0; }; name = Release; }; From da0a2e8d36390d6550bd6c4b4b2d9fce7f854f1b Mon Sep 17 00:00:00 2001 From: Andrey Date: Wed, 25 Jul 2018 17:00:54 +0700 Subject: [PATCH 2/3] Rename public method from initWithURLRequest to initWithSRURLRequest MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fix problem with ITC processing reject issue: Non-public API usage: • The app references non-public selectors in SocketRocket: initWithURLRequest: If method names in your source code match the private Apple APIs listed above, altering your method names will help prevent this app from being flagged in future submissions. In addition, note that one or more of the above APIs may be located in a static library that was included with your app. If so, they must be removed. --- SocketRocket/SRWebSocket.h | 2 +- SocketRocket/SRWebSocket.m | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/SocketRocket/SRWebSocket.h b/SocketRocket/SRWebSocket.h index a3806f1a0..ecad542c7 100644 --- a/SocketRocket/SRWebSocket.h +++ b/SocketRocket/SRWebSocket.h @@ -131,7 +131,7 @@ extern NSString *const SRHTTPResponseErrorKey; @param request Request to initialize with. */ -- (instancetype)initWithURLRequest:(NSURLRequest *)request; +- (instancetype)initWithSRURLRequest:(NSURLRequest *)request; /** Initializes a web socket with a given `NSURLRequest`, specifying a transport security policy (e.g. SSL configuration). diff --git a/SocketRocket/SRWebSocket.m b/SocketRocket/SRWebSocket.m index 4e30aef54..31b1b0db5 100644 --- a/SocketRocket/SRWebSocket.m +++ b/SocketRocket/SRWebSocket.m @@ -213,7 +213,7 @@ - (instancetype)initWithURLRequest:(NSURLRequest *)request protocols:(NSArray Date: Wed, 25 Jul 2018 20:22:28 +0700 Subject: [PATCH 3/3] Set current project version for Dynamic target --- SocketRocket.xcodeproj/project.pbxproj | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/SocketRocket.xcodeproj/project.pbxproj b/SocketRocket.xcodeproj/project.pbxproj index 57e19f2d6..0c5cb637e 100644 --- a/SocketRocket.xcodeproj/project.pbxproj +++ b/SocketRocket.xcodeproj/project.pbxproj @@ -1173,6 +1173,8 @@ isa = XCBuildConfiguration; baseConfigurationReference = 81D647591D2CA6A100690609 /* SocketRocket-iOS-Dynamic.xcconfig */; buildSettings = { + CURRENT_PROJECT_VERSION = 1.0; + DYLIB_CURRENT_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = YES; }; name = Debug; @@ -1181,6 +1183,8 @@ isa = XCBuildConfiguration; baseConfigurationReference = 81D647591D2CA6A100690609 /* SocketRocket-iOS-Dynamic.xcconfig */; buildSettings = { + CURRENT_PROJECT_VERSION = 1.0; + DYLIB_CURRENT_VERSION = 1.0; MTL_ENABLE_DEBUG_INFO = NO; }; name = Release;