chore: prefix log level consts, minor package updates #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the SDK, I found it difficult to use the log level consts and to assign a log level in the plugin configuration struct.
This changes the *LogLevel field to use a non-pointer type, and updates the code accordingly. I think this is ok, since we've define the
iota
0 value to aOff
constant. This will be the default / zero-value of the type when left unset in a struct.Also, I have prefixed these log level const names with
LogLevel
-- I think it makes it more clear when looking at the name, e.g.extism.LogLevelInfo
vs.extism.Info
Additionally, although unrelated, this PR includes a couple minor changes to use non-deprecated functions from
io
&os
packages vs.ioutil
.