chore: prefix log level consts, minor package updates #39
Conversation
|
Also just realized the change regarding the We could make the starting |
|
@mhmd-azeez -- I am not sure why the latest commit breaks tests. Would you mind picking this up? I am traveling today and will be offline for a bit. Ultimately, I'd like to preserve the ergonomics of using the non-pointer value, without cluttering the public exported consts. |
|
@nilslice sure |
There was a problem hiding this comment.
@nilslice I love the unexported logLevelUnset solution, the tests are now working too
While using the SDK, I found it difficult to use the log level consts and to assign a log level in the plugin configuration struct.
This changes the *LogLevel field to use a non-pointer type, and updates the code accordingly. I think this is ok, since we've define the
iota0 value to aOffconstant. This will be the default / zero-value of the type when left unset in a struct.Also, I have prefixed these log level const names with
LogLevel-- I think it makes it more clear when looking at the name, e.g.extism.LogLevelInfovs.extism.InfoAdditionally, although unrelated, this PR includes a couple minor changes to use non-deprecated functions from
io&ospackages vs.ioutil.