From 2d18e9f09331e9363d2254b480b41f4c9b1a5e26 Mon Sep 17 00:00:00 2001 From: Alex Bair Date: Fri, 18 Oct 2024 11:00:37 -0400 Subject: [PATCH] source-hubspot-native: add more email event types We've encountered even more email event types and expand the model to include them. Interestingly, the `SUPPRESSED` type isn't documented in HubSpot's docs but we have seen it used in existing records. The similarly named `SUPPRESSION` type is listed in the docs; I'm not sure if this is a typo on HubSpot's end, or if they have an undocumented `SUPPRESSED` type. If it turns out `SUPPRESSION` is a HubSpot typo, we can remove it later. --- source-hubspot-native/source_hubspot_native/models.py | 2 ++ .../tests/snapshots/snapshots__discover__stdout.json | 2 ++ 2 files changed, 4 insertions(+) diff --git a/source-hubspot-native/source_hubspot_native/models.py b/source-hubspot-native/source_hubspot_native/models.py index d2aab326f..34e94bd0c 100644 --- a/source-hubspot-native/source_hubspot_native/models.py +++ b/source-hubspot-native/source_hubspot_native/models.py @@ -390,10 +390,12 @@ class EmailEvent(BaseDocument, extra="allow"): "BOUNCE", "OPEN", "CLICK", + "PRINT", "FORWARD", "STATUSCHANGE", "SPAMREPORT", "SUPPRESSED", + "SUPPRESSION", # "SUPPRESSION" is documented in HubSpot's docs, but "SUPPRESSED" isn't. We've seen "SUPPRESSED" events, so "SUPPRESSION" events might not actually occur. "UNBOUNCE", # This is not actually a type reported by HubSpot, but the absence of the "type" field means its an UNBOUNCE type. ] = Field( default="UNBOUNCE", diff --git a/source-hubspot-native/tests/snapshots/snapshots__discover__stdout.json b/source-hubspot-native/tests/snapshots/snapshots__discover__stdout.json index 990108f63..8abd89e9b 100644 --- a/source-hubspot-native/tests/snapshots/snapshots__discover__stdout.json +++ b/source-hubspot-native/tests/snapshots/snapshots__discover__stdout.json @@ -1128,10 +1128,12 @@ "BOUNCE", "OPEN", "CLICK", + "PRINT", "FORWARD", "STATUSCHANGE", "SPAMREPORT", "SUPPRESSED", + "SUPPRESSION", "UNBOUNCE" ], "title": "Type",