Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Packit #46

Open
martinezjavier opened this issue Apr 19, 2024 · 4 comments
Open

Integrate Packit #46

martinezjavier opened this issue Apr 19, 2024 · 4 comments

Comments

@martinezjavier
Copy link
Collaborator

Packit is a project aimed to automated the packaging for upstream projects and provides a GitHub app.

By using the Packit-as-a-Service GitHub app, the project could drop the create-src.rpm.sh script.

@ericcurtin
Copy link
Owner

ericcurtin commented Apr 20, 2024

@martinezjavier btw I know how much of a graphics and libcamera guru you are. So if you feel the need to rewrite large chunks of anything here feel free. I remember being not so happy about some memory management things in this project, but it's so long ago I can't remember if it was file sink, kms sink, sdl sink, libcamera, etc.

But at least we have a reference implementation in kms sink.

And it's probably obvious, but significant parts of this are based off the "cam" reference implementation in libcamera, so a fair amount got contributed back to libcamera.

@ericcurtin
Copy link
Owner

I did the first part of the packit thing:

packit/notifications#604

I'm planning on taking some time off next week, so just a heads up, I'll be wrapping up for a little bit.

@ericcurtin
Copy link
Owner

ericcurtin commented Apr 23, 2024

Another thing to keep in mind @martinezjavier . I found when I was looking at this, that you can spin up a Wayland embedded implementation or SDL KMSDRM faster than you can get the camera frames to start processing, if this is true on your hardware it probably doesn't make sense to write custom KMS/DRM code (it can be a waste of time since there are mature things out there), just start camera and display in parallel and the camera will feed wayland/sdl when it's ready.

But if you can get camera frames faster than you can spin up something like libweston/sdl . It starts to make sense to write custom KMS code like https://github.com/ericcurtin/twincam/blob/main/src/kms_sink.cpp (well it makes sense if you need to save a few more milliseconds).

It's kinda different to plymouth from that perspective, plymouth doesn't need to wait for a camera to display things.

@ericcurtin
Copy link
Owner

Twincam works as an everyday desktop application also with SDL sink, that's useful for testing sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants