From a366e4e4874326f2b24c7cfc64f1eff22713769f Mon Sep 17 00:00:00 2001
From: Charles Treatman <ctreatman@equinix.com>
Date: Fri, 30 Aug 2024 09:51:44 -0500
Subject: [PATCH] chore(ci): tell golangci-lint to report all issues

By default, golangci-lint will only report a certain number of
issues per linter and a certain number of the same issue per
run.  That adds unnecessary turnaround time when fixing issues.

This PR updates our golangci-lint config file to tell the linter
to report all errors.

The golangci-lint config structure has changed quite a bit since
v1.56, so rather than fight their docs I'm also upgrading the
linter to the latest.
---
 .golangci.yaml | 7 +++++--
 GNUmakefile    | 2 +-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/.golangci.yaml b/.golangci.yaml
index 76de1758d..88eef32ff 100644
--- a/.golangci.yaml
+++ b/.golangci.yaml
@@ -1,7 +1,5 @@
 run:
   modules-download-mode: readonly
-  skip-dirs:
-    - cmd/migration-tool
 linters:
   enable:
     - errcheck
@@ -11,3 +9,8 @@ linters:
     - ineffassign
     - staticcheck
     - unused
+issues:
+  max-issues-per-linter: 0
+  max-same-issues: 0
+  exclude-dirs:
+    - cmd/migration-tool
diff --git a/GNUmakefile b/GNUmakefile
index c5a5a5141..e49faca1f 100644
--- a/GNUmakefile
+++ b/GNUmakefile
@@ -11,7 +11,7 @@ ACCTEST_COUNT       ?= 1
 GOFMT_FILES         ?=$$(find . -name '*.go' |grep -v vendor)
 PKG_NAME            =equinix
 
-GOLANGCI_LINT_VERSION=v1.56
+GOLANGCI_LINT_VERSION=v1.60
 GOLANGCI_LINT=go run github.com/golangci/golangci-lint/cmd/golangci-lint@${GOLANGCI_LINT_VERSION}
 
 ifneq ($(origin TESTS_REGEXP), undefined)