-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection pool DEBUG
logs & tracing.
#508
Open
Labels
enhancement
New feature or request
Comments
Regarding the events I was thinking about these:
Do you think these make sense? It would at least cover my needs, but maybe there are some metrics I'm not thinking about. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
tomchristie
changed the title
Add connection pool information to 'trace' extension.
Add connection pool Jun 14, 2023
DEBUG
logs & tracing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Escalated from discussion #505
Originally posted by inikolaev February 7, 2022
Hello!
Can you advise some way to monitor connection pool, specifically for the
AsyncClient
?What I would like to know is the following:
I could potentially get some numbers using existing
request
andresponse
hook, what I don't know is whenrequest
hook is fired - does it fire before connection is acquired or after - it's not very clear to me from the documentation. But this should be easy to check.Perhaps there could be added hooks into the connection pool or maybe someone from the community does this in a different way somehow already?
Currently the "trace" extension doesn't provide any visibility around the connection pooling.
It would be neat if we had events around this. I'm not sure exactly what set of events we'd want, but essentially we'd like to be able to track information around when connections are added or removed from the pool, and when connections become active or idle.
The first step here would be to determine what set of events we'd want to see, sketch out how the documentation ought to look once we've added those. Once that's done we can tackle the implementation.
The text was updated successfully, but these errors were encountered: