-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsafe code #31
Comments
I took a look at safe_transmute, but, despite it's name, it's not safe. We'll probably need to iterate through bytes and create structs/arrays manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For peace of mind it would be nice if steward was free of unsafe code. Currently it looks like there are a few unsafe blocks lying around doing transmutes, and if those are just there for performance then 1) figure out whether or not the performance of those bits of code actually matters, and 2) figure out if we can't defer that unsafe code to some more standard/tested library.
The text was updated successfully, but these errors were encountered: