Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Checkout page to use React-Final-Form to manage form state and accurately run validations #109

Open
3 tasks
onggunhao opened this issue Oct 4, 2019 · 0 comments
Open
3 tasks

Refactor Checkout page to use React-Final-Form to manage form state and accurately run validations #109

onggunhao opened this issue Oct 4, 2019 · 0 comments

Comments

@onggunhao
Copy link
Collaborator

  • investmentAmount should not be tracked as a state variable outside of react-final-form, but use mutators to change it based on button input

See: https://medium.com/@erikras/final-form-arrays-and-mutators-13159cb7d285

  • Validations should only run after user presses submit (it currently runs on form blur)
  • Validate that amount is more than 10 Dai? (should we have this?)
@adibas03 adibas03 assigned adibas03 and unassigned adibas03 Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@onggunhao @adibas03