Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 6.7.2 onwards seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) #435

Open
Stoobaart opened this issue Jan 29, 2020 · 2 comments

Comments

@Stoobaart
Copy link

Stoobaart commented Jan 29, 2020

Not sure what's causing this bug, but it appears that ember-fetch is not transpiling to es5 on version 6.7.2 and over

Using Ember-cli 3.15.1
Confirmed using es-check

Reproduction steps:
In terminal:
npm i es-check -g
Using an Ember app with ember fetch version 6.7.2 or over
npm i
ember build --environment production
es-check es5 './dist/**/*.js'

Expected result: ES-Check: there were no ES version matching errors!

Actual result: ES-Check: there were 1 ES version matching errors.
· erroring file: ./dist/ember-fetch/fetch-fastboot-38cfd9007f94f81f5a2bc13690efc343.js
· error: SyntaxError: The keyword 'const' is reserved (3:0)

We get the expected result with version 6.7.0

@Stoobaart Stoobaart changed the title Version 6.7.2 seems not to transpile to es5 Version 6.7.2 seems not to transpile to es5 (IE11 Blank screen, with no console errors) Jan 29, 2020
@Stoobaart Stoobaart changed the title Version 6.7.2 seems not to transpile to es5 (IE11 Blank screen, with no console errors) Version 6.7.2 seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) Jan 29, 2020
@Stoobaart Stoobaart changed the title Version 6.7.2 seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) Version 6.7.2 onwards seems not to transpile to es5 (Caused IE11 Blank screen, with no console errors) Jan 29, 2020
@xg-wang
Copy link
Member

xg-wang commented Feb 2, 2020

const from fetch-fastboot.js is from this line https://github.com/ember-cli/ember-fetch/blob/v6.7.2/public/fetch-fastboot.js#L16.
The file only runs in Fastboot(node). And const is available in pretty much all nodejs versions.
Does other dis/**/*.js files pass the test?

@Stoobaart
Copy link
Author

Yes, all other packages pass, this is the only one that fails. I'm not sure at all what's causing the issue, but it went away when I down graded to 6.7.0, thought it would be best to let someone know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants