Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify RoPE strategies #388

Open
jonatanklosko opened this issue Aug 6, 2024 · 0 comments
Open

Unify RoPE strategies #388

jonatanklosko opened this issue Aug 6, 2024 · 0 comments
Labels
kind:chore Internal improvements

Comments

@jonatanklosko
Copy link
Member

There has been some effort in hf/transformers to extract and share RoPE types across models, so we should be able to unify more, especially the loading/conversion parts. Some of the improvements are still in progress. A few relevant PRs:
@jonatanklosko jonatanklosko added the kind:chore Internal improvements label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:chore Internal improvements
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonatanklosko