Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code review and refactoring #2

Open
papachristoumarios opened this issue Aug 1, 2019 · 4 comments
Open

Code review and refactoring #2

papachristoumarios opened this issue Aug 1, 2019 · 4 comments
Assignees
@spapadiamantis

Comments

@papachristoumarios
Copy link
Collaborator

The following issue will consist of general comments and individual comments referring to certain files. Reviews for each file will be posted as separate answers.
@papachristoumarios
Copy link
Collaborator Author

entity_recognizer.py

  • Remove unecessary flags such as use_spacy
  • Format PEP8
  • Schema examples in wiki

@papachristoumarios
Copy link
Collaborator Author

dataset_creator.py

  • Can you move the desired functionality to pparser.py and codifier.py, since (ideally) this must be done in less passes?

@papachristoumarios
Copy link
Collaborator Author

papachristoumarios commented Aug 1, 2019 •
edited
Loading

train_doc2vec.py

  • Move it to scripts?

@papachristoumarios
Copy link
Collaborator Author

train_tf_doc2vec.py

What is the desired functionality of the file? Is the code really working?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spapadiamantis spapadiamantis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@papachristoumarios @spapadiamantis