Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bufferoverrun as subdomain source #112

Closed
Tracked by #51
edoardottt opened this issue Oct 12, 2023 · 4 comments
Closed
Tracked by #51

Remove bufferoverrun as subdomain source #112

edoardottt opened this issue Oct 12, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request go good first issue Good for newcomers GopherZone hacktoberfest help wanted Extra attention is needed

Comments

@edoardottt
Copy link
Owner

edoardottt commented Oct 12, 2023

#51 (comment)

@edoardottt edoardottt added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest GopherZone go labels Oct 12, 2023
@carlosfrodrigues
Copy link

Hello,
I'm interested in this one. Could you assign this for me?

@edoardottt
Copy link
Owner Author

For sure @carlosfrodrigues ! It's not needed to delete completely this file https://github.com/edoardottt/scilla/blob/main/pkg/opendb/bufferoverrun.go. It's okay to remove that source in the enumeration phase in other files.

Let me know if you need some guidance :)

@carlosfrodrigues
Copy link

carlosfrodrigues commented Oct 12, 2023

Hi @edoardottt , I was looking at the code. Isn't bufferoverrun already commented on the runner.go, so it's already disabled, right?

// bufferOverrun := opendb.BufferOverrunSubdomains(urlUtils.CleanProtocol(target), false)

@edoardottt
Copy link
Owner Author

Yes, sorry you're right.

If you want you can take #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go good first issue Good for newcomers GopherZone hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants