Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get into upstream QtCreator #3

Open
ChALkeR opened this issue Jul 27, 2017 · 14 comments
Open

Get into upstream QtCreator #3

ChALkeR opened this issue Jul 27, 2017 · 14 comments

Comments

@ChALkeR
Copy link

ChALkeR commented Jul 27, 2017

In #1 (comment) it was mentioned:

So, in future it will be possible to include the plugin in the QtCreator distribution.

This plugin seems to work, and it would resolve QTCREATORBUG-14013, I guess.

So, any plans for including the plugin into the QtCreator upstream distribution?

@hgraeber
Copy link
Member

Sure, the main functionality, reading editorconfig files and applying them to files, is ready. I think the best solution for spreading qtcreator plugins is to provide them upstream. Maybe, despite of having some additional plans for it, I shall do it now.

@matpen
Copy link

matpen commented Nov 24, 2017

Are there any updates regarding this? The bug on QtCreator seems to have no activity...

@dail8859
Copy link
Member

@hgraeber I see the hold up for that bug is due to the 3rd party libraries of editorconfig-core-c and pcre. Recently I started implementing the editorconfig core in pure Qt5 (for my own purposes) that does not rely on any outside libraries. I plan on releasing this "soon" if/when I get some free time to test it some more. I'm assuming this would be of interest to you?

@hgraeber
Copy link
Member

@dail8859 My own implementation based on Qt5 is nearly ready and I will publish it here as part of the editorconfig project, too. Nevertheless thanks for your offer.If your code is accessible for me, I will have a look. Maybe we can join forces.

@dail8859
Copy link
Member

@hgraeber Good to hear. After trying to run my version against the editorconfig-core-test repo it seems there are quite a few more corner cases to handle rather than the simple wildcard patterns described on the editor config website...so given the holidays and the new year I might not be able to get back to working on it for several more weeks. If/when you release yours I will definitely be interested it checking it out.

@arBmind
Copy link

arBmind commented Aug 3, 2018

Any updates on this?

Also Qt Creator 4.7.0 has received no build so far. Am I missing something?

@hgraeber
Copy link
Member

hgraeber commented Aug 4, 2018

Upstream doesn't like additional dependencies like editorconfig-core-c and pcre. It already has pcre2.
I would like to have an editor-core-qt, which extensively uses qt instead. I am already working on it and will push it to github when it passes the most basic unit tests.

I will make a build for qt-creator soon.

@KOLANICH
Copy link

pcre
pcre2

Why not std::regex?

@hgraeber
Copy link
Member

@KOLANICH

Why not std::regex?

pcre2 is not my choice, but used indirectly via editorconfig-core-c. When editorconfig-qtcreator will go upstream, I aim to replace editorconfig-core-c with a more Qt-ish core and use QRegularExpression (Which uses a copy of pcre2 internally) instead. std::regex is tabou, because Qt and QtCreator shall work with older C++ compilers and runtime libraries, too.

@dail8859
Copy link
Member

dail8859 commented Apr 19, 2020

@redtide
Copy link
Contributor

redtide commented Dec 18, 2020

hello, is there any news about this?

@hgraeber
Copy link
Member

I want to switch to editorconfig-core-qt, which is not ready yet. This one uses Qt functionality for regex and maybe be more acceptable for inclusion in qtcreator.

@hgraeber
Copy link
Member

Editorconfig-qtcretor is on the way to become part of qtcreator. It will use editorconfig-core-c and possibly editorconfig-core-qt later.

@xuhdev
Copy link
Member

xuhdev commented Jul 30, 2021

This is good news! Let me know if you need any help regarding to editorconfig-core-c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants