Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace os.path with pathlib #179

Open
trag1c opened this issue Apr 20, 2024 · 3 comments · May be fixed by #182
Open

Replace os.path with pathlib #179

trag1c opened this issue Apr 20, 2024 · 3 comments · May be fixed by #182
Assignees
@econchick @trag1c
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@trag1c
Copy link

trag1c commented Apr 20, 2024

pathlib offers a simpler and more human-friendly way of dealing with paths and it seems like interrogate mostly uses os.path.

I believe changing this would be more in line with CONTRIBUTING.md 😉

interrogate tries to take advantage of modern features whenever possible

I'd be happy to work on this if you find this issue reasonable :)
@trag1c trag1c added enhancement New feature or request needs triage Issue needs triaging labels Apr 20, 2024
@econchick
Copy link
Owner

Hey @trag1c - certainly would welcome a patch for this. I can't remember why os.path was originally chosen, it may have been something to do with Windows machines. Or I might be making it up. Either way, so long as it works on Windows + Unix, I'd appreciate it!

@econchick econchick added good first issue Good for newcomers and removed needs triage Issue needs triaging labels Apr 23, 2024
@trag1c
Copy link
Author

trag1c commented Apr 23, 2024 •
edited
Loading

Roger that! Though I think I'll wait for #178 (where I've left a few tips ^^) to merge so that it's easier for me to make the transition if that's okay 😄

@econchick
Copy link
Owner

#178 is all set (which you've probably seen) - sorry for the lag!

@trag1c trag1c linked a pull request May 22, 2024 that will close this issue
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@econchick econchick

@trag1c trag1c

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced os.path with pathlib trag1c/interrogate
2 participants
@econchick @trag1c