Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection with custom line spacing only pads on the bottom, not the top #1396

Open
gnaatz opened this issue May 27, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@gnaatz
Copy link

gnaatz commented May 27, 2024

When selecting a custom line spacing (Settings -> General-> Editors -> Text Editors -> Line spacing) and selecting a line in an editor, the selection is only padded to the bottom but not the top. This makes for an awkward feel and does not seem to be expected.
I do not know, whether the behaviour changed anytime before or whether this always was the case.

It would be expected for the line spacing to be equal on top an bottom when having a line highlighted.

This happens on the newest build on Mac.

Screenshots:
This is where the setting is located:
Screenshot 2024-05-28 at 11 08 55

This is the current situation:
Screenshot 2024-05-28 at 11 10 47
I would expect the padding of the line select to be equidistant from the text on top and bottom.

(This might be considered an enhancement, but I do believe this is not intentional in the first place)

@gnaatz gnaatz added the bug Something isn't working label May 27, 2024
@HannesWell
Copy link
Member

@gnaatz, thank you for your report.
Could you please provide a screenshot of such text selection and of the exact preference you are referring to, because at least under Windows I can't find that exact preference.
Please also provide the versions of Eclipse until it was working as expected and since when it started to look differently.

Furthermore I assume, although the preference is probably implemented in this repo, actual implementation is in SWT. So depending on what has changed exactly, this issue maybe will be transferred to SWT by us (but this isn't a problem for now).

@gnaatz
Copy link
Author

gnaatz commented Jul 11, 2024

Linking SWT Issue i found (by chance): eclipse-platform/eclipse.platform.swt#1286

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants