Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove isPrimitiveValueTypeClass #20398

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a7ehuo
Copy link
Contributor

@a7ehuo a7ehuo commented Oct 23, 2024

Also updated code comments where the old primitive value type is referenced

Related: #18157

@a7ehuo a7ehuo requested a review from dsouzai as a code owner October 23, 2024 12:49
@a7ehuo a7ehuo requested review from hzongaro and removed request for dsouzai October 23, 2024 12:49
@a7ehuo
Copy link
Contributor Author

a7ehuo commented Oct 23, 2024

@hzongaro May I ask you to review this change? Thank you!

@hangshao0 hangshao0 added project:valhalla Used to track Project Valhalla related work comp:jit labels Oct 23, 2024
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few comments.

runtime/compiler/optimizer/EscapeAnalysis.cpp Outdated Show resolved Hide resolved
runtime/compiler/optimizer/EscapeAnalysis.cpp Outdated Show resolved Hide resolved
runtime/compiler/compile/J9Compilation.cpp Outdated Show resolved Hide resolved
runtime/compiler/optimizer/J9ValuePropagation.cpp Outdated Show resolved Hide resolved
@hzongaro hzongaro self-assigned this Oct 23, 2024
Also updated code comments where the old
primitive value type is referenced

Related: eclipse-openj9#18157
Signed-off-by: Annabelle Huo <Annabelle.Huo@ibm.com>
@a7ehuo a7ehuo force-pushed the valuetype-remove-isPrimitiveValueTypeClass branch from 9fd2f09 to 7bc96d5 Compare October 23, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants