Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show C/C++ debug actions only when C/C++ launch configuration is added to Debug View #865

Open
raghucssit opened this issue Jul 17, 2024 · 2 comments

Comments

@raghucssit
Copy link
Contributor

Problem:
Some of the C/C++ contributed actions to Debug related to views have no visibility control. They are always shown up irrespective of C/C++ launch configuration available in Debug View.
This distracts the developers who have JDT and CDT both and use them independently.
Example: Instruction Stepping Mode
InstructionSteppingMode
We need to restrict their visibility only when there is an active C/C++ application being run/debug.

Analysis:
Instruction Stepping Mode is contributed to org.eclipse.debug.ui.DebugView using extension point <extension point="org.eclipse.ui.viewActions">. This extension point does not support <visibleWhen> expression.
Also this extension point is deprecated.

Solution:
Replace the <extension point="org.eclipse.ui.viewActions"> with the <menuContribution locationURI="toolbar:org.eclipse.debug.ui.DebugView?after=additions"> and migrate <action id="org.eclipse.cdt.debug.internal.ui.actions.ToggleInstructionStepModeActionDelegate" /> to <command commandId="org.eclipse.cdt.debug.internal.ui.actions.ToggleInstructionStepModeCommand"/>.

We can migrate one action at time. We can start with Instruction Stepping Mode

@raghucssit
Copy link
Contributor Author

This bug/enhancement was also reported earlier https://bugs.eclipse.org/bugs/show_bug.cgi?id=527190.

@raghucssit
Copy link
Contributor Author

@iloveeclipse FYI

raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 18, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 18, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 29, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 31, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 31, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Jul 31, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 8, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 12, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 12, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 14, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 15, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 20, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 21, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 23, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 23, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
raghucssit added a commit to raghucssit/cdt that referenced this issue Aug 24, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
Torbjorn-Svensson pushed a commit to raghucssit/cdt that referenced this issue Aug 26, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see eclipse-cdt#865
Torbjorn-Svensson pushed a commit that referenced this issue Aug 27, 2024
ToggleInstructionStepModeCommand.

All the contributions of the the action has been replaced
ToggleInstructionStepModeCommand.
Enabled when introduced. Which enabled the command only when C/CPP
application is under debug in Debug View.

see #865
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant