Apparent regression from 3.3.0: SD-related functions throw errors

[FerGT50]

Up to arduino-pico v3.3.0, this SD benchmark worked perfectly:

/*
 * This program is a simple binary write/read benchmark
 */
#include "SdFat.h"
#include "sdios.h"
#include "FreeStack.h"

// SD_FAT_TYPE = 0 for SdFat/File as defined in SdFatConfig.h,
// 1 for FAT16/FAT32, 2 for exFAT, 3 for FAT16/FAT32 and exFAT.
#define SD_FAT_TYPE 3
/*
  Change the value of SD_CS_PIN if you are using SPI and
  your hardware does not use the default value, SS.
  Common values are:
  Arduino Ethernet shield: pin 4
  Sparkfun SD shield: pin 8
  Adafruit SD shields and modules: pin 10

  RP Pico Notes:
  ==============
  Update 20230706-1:
  Board package 3.3.0, bundled library (ESP8266SdFat v2.1.1)

  (to show that GCC optimizations do not affect SD performances)
  250 MHz clock, -Os, 50 MHz SPI , binary size 72412, UF2 181248 bytes
  128 GB microSD exFAT, 64 KB buffer
  read 2.42 MB/s 27ms
  write 2.39 MB/s 43ms
  
  250 MHz clock, -Ofast, 50 MHz SPI , binary size 84420
  128 GB microSD exFAT, 64 KB buffer (+/- the size of a low-quality JPEG from a OV2640 camera):
  read 2.44 MB/s 27ms
  write 2.4 MB/s 44ms (about 22 FPS without double-buffering)
  
  250 MHz clock, -Ofast, 50 MHz SPI
  128 GB microSD exFAT, 16 KB buffer:
  read 2.44 MB/s 7ms
  write 2.4 MB/s 26ms
  
  240 MHz clock, -Ofast, 80 MHz SPI
  128 GB microSD exFAT, 16 KB buffer:
  read 2.43 MB/s 7ms
  write 2.4 MB/s 24ms
  
  Write latency seems to be erratic
  SD_CLK_MHZ seems to be ignored, maybe it's overwritten by CPU_CLK / some divisor
  Large BUF_SIZE seems counter-productive
*/

// SDCARD_SS_PIN is defined for the built-in SD on some boards.
#ifndef SDCARD_SS_PIN
const uint8_t SD_CS_PIN = SS;
#else  // SDCARD_SS_PIN
// Assume built-in SD is used.
const uint8_t SD_CS_PIN = 17;
#endif  // SDCARD_SS_PIN

// Try max SPI clock for an SD. Reduce SPI_CLOCK if errors occur.
#define SPI_CLOCK SD_SCK_MHZ(50)

// Try to select the best SD card configuration.
#if HAS_SDIO_CLASS
#define SD_CONFIG SdioConfig(FIFO_SDIO)
#elif ENABLE_DEDICATED_SPI
#define SD_CONFIG SdSpiConfig(SD_CS_PIN, DEDICATED_SPI, SPI_CLOCK)
#else  // HAS_SDIO_CLASS
#define SD_CONFIG SdSpiConfig(SD_CS_PIN, SHARED_SPI, SPI_CLOCK)
#endif  // HAS_SDIO_CLASS

// Set PRE_ALLOCATE true to pre-allocate file clusters.
const bool PRE_ALLOCATE = true;

// Set SKIP_FIRST_LATENCY true if the first read/write to the SD can
// be avoid by writing a file header or reading the first record.
const bool SKIP_FIRST_LATENCY = true;

// Size of read/write.
const size_t BUF_SIZE = 65536;

// File size in MB where MB = 1,000,000 bytes.
const uint32_t FILE_SIZE_MB = 256;

// Write pass count.
const uint8_t WRITE_COUNT = 2;

// Read pass count.
const uint8_t READ_COUNT = 2;
//==============================================================================
// End of configuration constants.
//------------------------------------------------------------------------------
// File size in bytes.
const uint32_t FILE_SIZE = 1000000UL*FILE_SIZE_MB;

// Insure 4-byte alignment.
uint32_t buf32[(BUF_SIZE + 3)/4];
uint8_t* buf = (uint8_t*)buf32;

#if SD_FAT_TYPE == 0
SdFat sd;
File file;
#elif SD_FAT_TYPE == 1
SdFat32 sd;
File32 file;
#elif SD_FAT_TYPE == 2
SdExFat sd;
ExFile file;
#elif SD_FAT_TYPE == 3
SdFs sd;
FsFile file;
#else  // SD_FAT_TYPE
#error Invalid SD_FAT_TYPE
#endif  // SD_FAT_TYPE

// Serial output stream
ArduinoOutStream cout(Serial);
//------------------------------------------------------------------------------
// Store error strings in flash to save RAM.
#define error(s) sd.errorHalt(&Serial, F(s))
//------------------------------------------------------------------------------
void cidDmp() {
  cid_t cid;
  if (!sd.card()->readCID(&cid)) {

    error("readCID failed");
  }
  cout << F("\nManufacturer ID: ");
  cout << hex << int(cid.mid) << dec << endl;
  cout << F("OEM ID: ") << cid.oid[0] << cid.oid[1] << endl;
  cout << F("Product: ");
  for (uint8_t i = 0; i < 5; i++) {
    cout << cid.pnm[i];
  }
  cout << F("\nVersion: ");
  cout << int(cid.prv_n) << '.' << int(cid.prv_m) << endl;
  cout << F("Serial number: ") << hex << cid.psn << dec << endl;
  cout << F("Manufacturing date: ");
  cout << int(cid.mdt_month) << '/';
  cout << (2000 + cid.mdt_year_low + 10 * cid.mdt_year_high) << endl;
  cout << endl;
}
//------------------------------------------------------------------------------
void clearSerialInput() {
  uint32_t m = micros();
  do {
    if (Serial.read() >= 0) {
      m = micros();
    }
  } while (micros() - m < 10000);
}
//------------------------------------------------------------------------------
void setup() {
  Serial.begin(115200);

  // Wait for USB Serial
  while (!Serial) {
    yield();
  }
  delay(1000);
  cout << F("\nUse a freshly formatted SD for best performance.\n");
  if (!ENABLE_DEDICATED_SPI) {
    cout << F(
      "\nSet ENABLE_DEDICATED_SPI nonzero in\n"
      "SdFatConfig.h for best SPI performance.\n");
  }
  // use uppercase in hex and use 0X base prefix
  cout << uppercase << showbase << endl;
}
//------------------------------------------------------------------------------
void loop() {
  float s;
  uint32_t t;
  uint32_t maxLatency;
  uint32_t minLatency;
  uint32_t totalLatency;
  bool skipLatency;

  // Discard any input.
  clearSerialInput();

  // F() stores strings in flash to save RAM
  cout << F("Type any character to start\n");
  while (!Serial.available()) {
    yield();
  }
#if HAS_UNUSED_STACK
  cout << F("FreeStack: ") << FreeStack() << endl;
#endif  // HAS_UNUSED_STACK

  if (!sd.begin(SD_CONFIG)) {
    sd.initErrorHalt(&Serial);
  }
  if (sd.fatType() == FAT_TYPE_EXFAT) {
    cout << F("Type is exFAT") << endl;
  } else {
    cout << F("Type is FAT") << int(sd.fatType()) << endl;
  }

  cout << F("Card size: ") << sd.card()->sectorCount()*512E-9;
  cout << F(" GB (GB = 1E9 bytes)") << endl;

  cidDmp();

  // open or create file - truncate existing file.
  if (!file.open("bench.dat", O_RDWR | O_CREAT | O_TRUNC)) {
    error("open failed");
  }

  // fill buf with known data
  if (BUF_SIZE > 1) {
    for (size_t i = 0; i < (BUF_SIZE - 2); i++) {
      buf[i] = 'A' + (i % 26);
    }
    buf[BUF_SIZE-2] = '\r';
  }
  buf[BUF_SIZE-1] = '\n';

  cout << F("FILE_SIZE_MB = ") << FILE_SIZE_MB << endl;
  cout << F("BUF_SIZE = ") << BUF_SIZE << F(" bytes\n");
  cout << F("Starting write test, please wait.") << endl << endl;

  // do write test
  uint32_t n = FILE_SIZE/BUF_SIZE;
  cout <<F("write speed and latency") << endl;
  cout << F("speed,max,min,avg") << endl;
  cout << F("KB/Sec,usec,usec,usec") << endl;
  for (uint8_t nTest = 0; nTest < WRITE_COUNT; nTest++) {
    file.truncate(0);
    if (PRE_ALLOCATE) {
      if (!file.preAllocate(FILE_SIZE)) {
        error("preAllocate failed");
      }
    }
    maxLatency = 0;
    minLatency = 9999999;
    totalLatency = 0;
    skipLatency = SKIP_FIRST_LATENCY;
    t = millis();
    for (uint32_t i = 0; i < n; i++) {
      uint32_t m = micros();
      if (file.write(buf, BUF_SIZE) != BUF_SIZE) {
        error("write failed");
      }
      m = micros() - m;
      totalLatency += m;
      if (skipLatency) {
        // Wait until first write to SD, not just a copy to the cache.
        skipLatency = file.curPosition() < 512;
      } else {
        if (maxLatency < m) {
          maxLatency = m;
        }
        if (minLatency > m) {
          minLatency = m;
        }
      }
    }
    file.sync();
    t = millis() - t;
    s = file.fileSize();
    cout << s/t <<',' << maxLatency << ',' << minLatency;
    cout << ',' << totalLatency/n << endl;
  }
  cout << endl << F("Starting read test, please wait.") << endl;
  cout << endl <<F("read speed and latency") << endl;
  cout << F("speed,max,min,avg") << endl;
  cout << F("KB/Sec,usec,usec,usec") << endl;

  // do read test
  for (uint8_t nTest = 0; nTest < READ_COUNT; nTest++) {
    file.rewind();
    maxLatency = 0;
    minLatency = 9999999;
    totalLatency = 0;
    skipLatency = SKIP_FIRST_LATENCY;
    t = millis();
    for (uint32_t i = 0; i < n; i++) {
      buf[BUF_SIZE-1] = 0;
      uint32_t m = micros();
      int32_t nr = file.read(buf, BUF_SIZE);
      if (nr != BUF_SIZE) {
        error("read failed");
      }
      m = micros() - m;
      totalLatency += m;
      if (buf[BUF_SIZE-1] != '\n') {

        error("data check error");
      }
      if (skipLatency) {
        skipLatency = false;
      } else {
        if (maxLatency < m) {
          maxLatency = m;
        }
        if (minLatency > m) {
          minLatency = m;
        }
      }
    }
    s = file.fileSize();
    t = millis() - t;
    cout << s/t <<',' << maxLatency << ',' << minLatency;
    cout << ',' << totalLatency/n << endl;
  }
  cout << endl << F("\n\tTest complete\n") << endl;
  file.close();
}

Now, with 3.8.1 (Arduino IDE 1.8.19, Windows 10), I get build errors:

Compiling sketch...
"C:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\tools\\pqt-python3\\1.0.1-base-3a57aed/python3" -I "C:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1/tools/signing.py" --mode header --publickey "F:\\Progetti\\Arduino\\PICO_SDbench/public.key" --out "D:\\Arduino\\arduino-build-output/core/Updater_Signing.h"
"C:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\tools\\pqt-gcc\\2.2.0-d04e724/bin/arm-none-eabi-g++" -I "D:\\Arduino\\arduino-build-output/core" -c -Werror=return-type -Wno-psabi -DCFG_TUSB_MCU=OPT_MCU_RP2040 -DUSBD_PID=0x000a -DUSBD_VID=0x2e8a -DUSBD_MAX_POWER_MA=250 "-DUSB_MANUFACTURER=\"Raspberry Pi\"" "-DUSB_PRODUCT=\"Pico\"" -DPICO_CYW43_ARCH_THREADSAFE_BACKGROUND=1 -DCYW43_LWIP=1 -DLWIP_IPV6=0 -DLWIP_IPV4=1 -DLWIP_IGMP=1 -DLWIP_CHECKSUM_CTRL_PER_NETIF=1 "-DARDUINO_VARIANT=\"rpipico\"" -DTARGET_RP2040 -DPICO_FLASH_SIZE_BYTES=2097152 -march=armv6-m -mcpu=cortex-m0plus -mthumb -ffunction-sections -fdata-sections -fno-exceptions -DARM_MATH_CM0_FAMILY -DARM_MATH_CM0_PLUS -MMD "-iprefixC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1/" "@C:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1/lib/platform_inc.txt" "-IC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1/include" -fno-rtti -std=gnu++17 -g -pipe -DF_CPU=133000000L -DARDUINO=10819 -DARDUINO_RASPBERRY_PI_PICO "-DBOARD_NAME=\"RASPBERRY_PI_PICO\"" -DARDUINO_ARCH_RP2040 -Os -DWIFICC=CYW43_COUNTRY_WORLDWIDE "-IC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1\\cores\\rp2040" "-IC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1\\variants\\rpipico" "-IC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1\\libraries\\ESP8266SdFat\\src" "-IC:\\Users\\Fernando\\AppData\\Local\\Arduino15\\packages\\rp2040\\hardware\\rp2040\\3.8.1\\libraries\\SPI\\src" "D:\\Arduino\\arduino-build-output\\sketch\\PICO_SDbench.ino.cpp" -o "D:\\Arduino\\arduino-build-output\\sketch\\PICO_SDbench.ino.cpp.o"
F:\Progetti\Arduino\PICO_SDbench\PICO_SDbench.ino: In function 'void cidDmp()':
PICO_SDbench:201:19: error: 'struct cid_t' has no member named 'prv_n'
  201 |   cout << int(cid.prv_n) << '.' << int(cid.prv_m) << endl;
      |                   ^~~~~
PICO_SDbench:201:44: error: 'struct cid_t' has no member named 'prv_m'
  201 |   cout << int(cid.prv_n) << '.' << int(cid.prv_m) << endl;
      |                                            ^~~~~
PICO_SDbench:202:39: error: invalid use of non-static member function 'uint32_t cid_t::psn() const'
  202 |   cout << F("Serial number: ") << hex << cid.psn << dec << endl;
      |   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~
In file included from C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/SdCard/SdSpiCard.h:35,
                 from C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/SdCard/SdCard.h:31,
                 from c:\users\fernando\appdata\local\arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\esp8266sdfat\src\common\fsblockdevice.h:27,
                 from C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/ExFatLib/ExFatFormatter.h:27,
                 from C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/ExFatLib/ExFatLib.h:27,
                 from C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/SdFat.h:31,
                 from F:\Progetti\Arduino\PICO_SDbench\PICO_SDbench.ino:6:
C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat\src/SdCard/SdCardInfo.h:311:12: note: declared here
  311 |   uint32_t psn() const {
      |            ^~~
PICO_SDbench:204:19: error: 'struct cid_t' has no member named 'mdt_month'; did you mean 'mdtMonth'?
  204 |   cout << int(cid.mdt_month) << '/';
      |                   ^~~~~~~~~
      |                   mdtMonth
PICO_SDbench:205:23: error: 'struct cid_t' has no member named 'mdt_year_low'
  205 |   cout << (2000 + cid.mdt_year_low + 10 * cid.mdt_year_high) << endl;
      |                       ^~~~~~~~~~~~
PICO_SDbench:205:47: error: 'struct cid_t' has no member named 'mdt_year_high'
  205 |   cout << (2000 + cid.mdt_year_low + 10 * cid.mdt_year_high) << endl;
      |                                               ^~~~~~~~~~~~~
Using library ESP8266SdFat at version 2.2.2 in folder: C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\ESP8266SdFat 
Using library SPI at version 1.0 in folder: C:\Users\Fernando\AppData\Local\Arduino15\packages\rp2040\hardware\rp2040\3.8.1\libraries\SPI 
exit status 1
'struct cid_t' has no member named 'prv_n'

Did something change between 3.3.0 and 3.8.1, as far as SD library is concerned?
Is there something I can try?

Many thanks

[earlephilhower]

Version 2.2.2 of the upstream SDFat was merged and that stuicture you're using no longer has those elements.

[FerGT50]

Thanks