Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website: responsive layout broken at 320px breakpoint #2235

Open
1 task done
ianmcburnie opened this issue Dec 28, 2023 · 2 comments
Open
1 task done

website: responsive layout broken at 320px breakpoint #2235

ianmcburnie opened this issue Dec 28, 2023 · 2 comments

Comments

@ianmcburnie
Copy link
Contributor

I verified there's no existing issue for this bug.

  • There are no existing issues

Current behavior

Looks like the website layout got broken and has introduced horizontal scrolling somewhere along the line. Possibly in some of the more complex layout examples like toggle button group.

Screenshot 2023-12-28 at 12 45 30 PM

Expected behavior

No response

Skin version

17.0.0

Device/OS/Browser info

No response

Steps to reproduce

1.
2.
3.
...

Relevant code block

No response

Additional context

No response

@ArtBlue
Copy link
Contributor

ArtBlue commented Dec 28, 2023

We can verify this to be the case, but this may not be an issue. If I remember correctly, this may have been one of the drawbacks of the combination of having minimum button widths imposed and not being able to use container queries. I vaguely recall some compromises such as this, but we can verify.

@ianmcburnie
Copy link
Contributor Author

We can verify this to be the case, but this may not be an issue. If I remember correctly, this may have been one of the drawbacks of the combination of having minimum button widths imposed and not being able to use container queries. I vaguely recall some compromises such as this, but we can verify.

I am just meaning that our Skin website itself shouldn't break at 320px. If you are saying this breakage is unavoidable/intentional then perhaps these layouts should be moved to a different page to avoid breaking the main skin page at 320. Feels like we need to demonstrate some kind of responsive solution though.

@agliga agliga added size: 2 and removed size: 2 labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants