Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notice: rework cta/footer attribute tags #1986

Open
agliga opened this issue Sep 19, 2023 · 2 comments
Open

notice: rework cta/footer attribute tags #1986

agliga opened this issue Sep 19, 2023 · 2 comments
Assignees
@agliga
Labels
component: notice size: 2 type: tech-debt

Comments

@agliga
Copy link
Contributor

agliga commented Sep 19, 2023

No description provided.

@agliga
Copy link
Contributor Author

agliga commented Sep 19, 2023

Should also relook at icon as well and change the value.

@agliga agliga added this to the 13.0.0 milestone Sep 19, 2023
@agliga agliga assigned agliga and unassigned saiponnada Nov 16, 2023
@agliga agliga removed this from the 13.0.0 milestone Dec 21, 2023
@agliga agliga added this to the 14.0.0 milestone May 22, 2024
@agliga
Copy link
Contributor Author

agliga commented May 22, 2024

Changes needed

  • change icon to be an attribute tag. Add a hide-icon attribute.
  • Rework cta/footer

@agliga agliga removed this from the 14.0.0 milestone Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agliga agliga

Labels
component: notice size: 2 type: tech-debt
Projects
eBayUI
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agliga @saiponnada