Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation inconsistency #2

Open
fmocking opened this issue Oct 15, 2021 · 1 comment
Open

Implementation inconsistency #2

fmocking opened this issue Oct 15, 2021 · 1 comment

Comments

@fmocking
Copy link

Hello, I was looking over the Tensorflow and Pytorch versions of the CPD model and realized they are inconsistent.

In Tensorflow version when we are converting input to the features there is an extra GVP layer. Here is the node embedding and edge embedding functions defined under StructuralFeatures which is called here. Right after this we apply another set of GVP layers for both edge and vertex embeddings.

Meanwhile in Pytorch version we are missing the GVP layers under StructuralFeatures. Instead edge and vertex features only normalize while converting the inputs to features under ProteinGraphDataset. Then just like in Tensorflow version GVP layers applied to normalized vertex and edge features.

Can you please clarify this issue?

@stgzr
Copy link

stgzr commented Aug 15, 2022

Same concern about the inconsistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants