Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open source service generation #44

Open
nipunn1313 opened this issue Sep 16, 2020 · 10 comments
Open

Open source service generation #44

nipunn1313 opened this issue Sep 16, 2020 · 10 comments
Labels
DBX Can only be completed by a Dropboxer

Comments

@nipunn1313
Copy link
Contributor

Currently there's some non-OSS service generation code at DBX which relies on this - which can come out as well (pb_service)

@ParkMyCar ParkMyCar added the DBX Can only be completed by a Dropboxer label Sep 17, 2020
@byblakeorriver
Copy link

Is there any estimate on when this may become available?

@nipunn1313
Copy link
Contributor Author

@ParkMyCar and I are working on it! Thanks for the interest.

We're trying to modernize the usage of futures before open sourcing it
(it's currently using a v/ old version of the futures library).

May just end up open sourcing it w/ the old version and upgrade usage of futures later - depending on how much extra time we get.

@nipunn1313
Copy link
Contributor Author

sorry! Dodged the question!

I'll look into it! It's been on the back burner. Will try to get an update to you in a week.
Can't promise it'll be in a good enough quality state to merge onto master (documentation, tests) - but should be able to get the code onto a branch to take an early look.

@nipunn1313
Copy link
Contributor Author

I did a code drop of what we got so far onto
https://github.com/dropbox/pb-jelly/tree/pb-jelly-svc

Doesn't work yet - but should let you see what's going on
Need to provide a couple of proto files, update to futures03, and eliminate some internal dependencies - but it's on its way

@byblakeorriver
Copy link

Oh wow! Thank you so much for the quick turn around! I’ll definitely be giving it a look see!

@ParkMyCar
Copy link
Contributor

Update: I have a WIP change internally at Dropbox to migrate pb-jelly-svc to use futures03. We'll work on getting that open sourced soon, and then we'll need to integrate with pb-jelly-gen 🙂

@SkamDart
Copy link

Any update on the status of this?

@ParkMyCar
Copy link
Contributor

@SkamDart thanks for the reminder, I got caught up in end of the year stuff but I'll try and make some progress here this week or next

@ParkMyCar
Copy link
Contributor

Update, I haven't forgotten about this, but haven't found the time to get it done yet. Thanks for being patient, and sorry to anyone who is waiting 🙂

@byblakeorriver
Copy link

Thanks for the update! No rush from me, just interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DBX Can only be completed by a Dropboxer
Projects
None yet
Development

No branches or pull requests

4 participants