Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup pb-gen #21

Open
ParkMyCar opened this issue Aug 26, 2020 · 1 comment
Open

Cleanup pb-gen #21

ParkMyCar opened this issue Aug 26, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@ParkMyCar
Copy link
Contributor

The API for pb-gen was written kind of hastily, we should remove the logging that is part of the implementation, and expose a properly documented builder struct so the code generation can have more options.
@ParkMyCar ParkMyCar added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 26, 2020
@ParkMyCar ParkMyCar mentioned this issue Aug 31, 2020
Merged
@ParkMyCar
Copy link
Contributor Author

This may have been closed by #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ParkMyCar