Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CONFIG_MMC_BROKEN_CD to U-Boot config #49

Open
8bitgc opened this issue May 9, 2021 · 2 comments
Open

Add CONFIG_MMC_BROKEN_CD to U-Boot config #49

8bitgc opened this issue May 9, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@8bitgc
Copy link

8bitgc commented May 9, 2021

This may allow PinePhones with damaged SD sockets to boot off SD.

Damaged card detect switch in microSD socket causes U-Boot to halt with:

Trying to boot from MMC1
MMC: no card present
spl: mmc init failed with error: -123
SPL: failed to boot from all boot devices
### ERROR ### Please RESET the board ###

It fails even though U-Boot is running from the SD card itself. mmc_start_init tries to initialize the card and fails on the card detection.

https://gitlab.com/pine64-org/u-boot/-/blob/master/drivers/mmc/mmc.c#L2867-2879

CONFIG_MMC_BROKEN_CD should allow U-Boot to continue ignoring the state of the card detection pin.

Some background information in this post https://forum.pine64.org/showthread.php?tid=13775

@8bitgc
Copy link
Author

8bitgc commented May 17, 2021

This seems to work. Compiled with CONFIG_MMC_BROKEN_CD and tested on a PinePhone with a broken card detection switch. https://github.com/8bitgc/Jumpdrive/tree/master/test

@8bitgc 8bitgc closed this as completed May 17, 2021
@Danct12
Copy link
Member

Danct12 commented May 17, 2021

Reopening the issue as this needs to be implemented to Jumpdrive.

@Danct12 Danct12 reopened this May 17, 2021
@Danct12 Danct12 added the enhancement New feature or request label May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants