Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FullAssemblySigningSupported should not be set in SourceBuildArcadeBuild.targets #4669

Open
mmitche opened this issue Oct 11, 2024 · 0 comments
Open

FullAssemblySigningSupported should not be set in SourceBuildArcadeBuild.targets #4669

mmitche opened this issue Oct 11, 2024 · 0 comments
Assignees
@mmitche
Labels
area-unified-build

Comments

@mmitche
Copy link
Member

mmitche commented Oct 11, 2024

We should not be setting properties like this (in this case, setting the default) in SourceBuildArcadeBuild.targets. The file should really only be for passthrough properties and setting new properties based on old ones.

Instead, this property should be set:

  • In the repo SB build scripts
  • In the VMR's build script, defaulting to false when building from source.
@mmitche mmitche self-assigned this Oct 11, 2024
@dotnet-issue-labeler dotnet-issue-labeler bot added area-build Improvements in source-build's own build process untriaged labels Oct 11, 2024
@MichaelSimons MichaelSimons added area-unified-build and removed area-build Improvements in source-build's own build process untriaged labels Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mmitche mmitche

Labels
area-unified-build
Projects
.NET Unified Build
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichaelSimons @mmitche