From d0b35e7c82971508dd1e342d784b0cf1d3a27b0a Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Wed, 15 Feb 2023 13:54:25 -0500 Subject: [PATCH 1/3] [iOS] Disable additional sourcegenerator tests These aren't necessary to run on mobile targets, so skip them. --- src/libraries/tests.proj | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ae22b2cc37058..239b6328d8afe 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -99,6 +99,9 @@ + + + From 3d95e7d2a64868a604f2017f7cef81b011616f1b Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Wed, 15 Feb 2023 15:28:12 -0500 Subject: [PATCH 2/3] Since they won't be run at all, add property to each csproj. That way they'll survive moves --- ...soft.Extensions.Logging.Generators.targets | 1 + .../JSImportGenerator.Unit.Tests.csproj | 1 + .../ComInterfaceGenerator.Tests.csproj | 1 + .../ComInterfaceGenerator.Unit.Tests.csproj | 1 + .../LibraryImportGenerator.Tests.csproj | 1 + .../LibraryImportGenerator.Unit.Tests.csproj | 1 + ...m.Text.Json.SourceGeneration.Tests.targets | 1 + ...t.Json.SourceGeneration.Unit.Tests.targets | 1 + src/libraries/tests.proj | 23 ------------------- 9 files changed, 8 insertions(+), 23 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets b/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets index abc32a36a56bf..0be59257e71af 100644 --- a/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets +++ b/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets @@ -5,6 +5,7 @@ true true enable + true diff --git a/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj index 424402c46596d..13d8aee646cfe 100644 --- a/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj @@ -3,6 +3,7 @@ $(NetCoreAppCurrent) enable true + true diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj index 56e29a19f19e1..3d30e2b3ecd1b 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj @@ -7,6 +7,7 @@ true false + true diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj index 64e7dd10a070d..ad24d957c2e61 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj @@ -6,6 +6,7 @@ Preview enable true + true diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj index ad8f6d61e84d5..53806f86d872f 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj @@ -4,6 +4,7 @@ true true false + true diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj index d3c7c3c2f5479..cc11058fa5ce5 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj @@ -4,6 +4,7 @@ $(NetCoreAppCurrent) enable true + true diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets index a569e0355b753..f080614fd3c5e 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets @@ -8,6 +8,7 @@ $(NoWarn);SYSLIB0020;SYSLIB1037;SYSLIB1038;SYSLIB1039 + true diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets index 08f362de05e7a..2b72fbcd8e997 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets @@ -2,6 +2,7 @@ $(NetCoreAppCurrent);$(NetFrameworkMinimum) true + true diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index 239b6328d8afe..ba67c1d9eb33d 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -81,29 +81,6 @@ - - - - - - - - - - - - - - - - - - - - From d29dab7b1c50ed14abdc340c3ba7184cbc4a0730 Mon Sep 17 00:00:00 2001 From: Steve Pfister Date: Thu, 16 Feb 2023 10:36:01 -0500 Subject: [PATCH 3/3] Exclude test projects that can't even build for ios / tvos --- .../Microsoft.Extensions.Logging.Generators.targets | 2 +- .../JSImportGenerator.Unit.Tests.csproj | 2 +- .../ComInterfaceGenerator.Tests.csproj | 1 - .../ComInterfaceGenerator.Unit.Tests.csproj | 1 - .../LibraryImportGenerator.Tests.csproj | 1 - .../LibraryImportGenerator.Unit.Tests.csproj | 1 - .../System.Text.Json.SourceGeneration.Tests.targets | 2 +- .../System.Text.Json.SourceGeneration.Unit.Tests.targets | 2 +- src/libraries/tests.proj | 7 +++++++ 9 files changed, 11 insertions(+), 8 deletions(-) diff --git a/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets b/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets index 0be59257e71af..584454e72a8cd 100644 --- a/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets +++ b/src/libraries/Microsoft.Extensions.Logging.Abstractions/tests/Microsoft.Extensions.Logging.Generators.Tests/Microsoft.Extensions.Logging.Generators.targets @@ -5,7 +5,7 @@ true true enable - true + true diff --git a/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj index 13d8aee646cfe..70e76ba4e5842 100644 --- a/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices.JavaScript/tests/JSImportGenerator.UnitTest/JSImportGenerator.Unit.Tests.csproj @@ -3,7 +3,7 @@ $(NetCoreAppCurrent) enable true - true + true diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj index 3d30e2b3ecd1b..56e29a19f19e1 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Tests/ComInterfaceGenerator.Tests.csproj @@ -7,7 +7,6 @@ true false - true diff --git a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj index ad24d957c2e61..64e7dd10a070d 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/ComInterfaceGenerator.Unit.Tests.csproj @@ -6,7 +6,6 @@ Preview enable true - true diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj index 53806f86d872f..ad8f6d61e84d5 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/LibraryImportGenerator.Tests.csproj @@ -4,7 +4,6 @@ true true false - true diff --git a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj index cc11058fa5ce5..d3c7c3c2f5479 100644 --- a/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj +++ b/src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.UnitTests/LibraryImportGenerator.Unit.Tests.csproj @@ -4,7 +4,6 @@ $(NetCoreAppCurrent) enable true - true diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets index f080614fd3c5e..38c891dc2df37 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/System.Text.Json.SourceGeneration.Tests.targets @@ -8,7 +8,7 @@ $(NoWarn);SYSLIB0020;SYSLIB1037;SYSLIB1038;SYSLIB1039 - true + true diff --git a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets index 2b72fbcd8e997..1556999049607 100644 --- a/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets +++ b/src/libraries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Unit.Tests/System.Text.Json.SourceGeneration.Unit.Tests.targets @@ -2,7 +2,7 @@ $(NetCoreAppCurrent);$(NetFrameworkMinimum) true - true + true diff --git a/src/libraries/tests.proj b/src/libraries/tests.proj index ba67c1d9eb33d..01f32cfaf5226 100644 --- a/src/libraries/tests.proj +++ b/src/libraries/tests.proj @@ -81,6 +81,13 @@ + + + + + + +