Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPMI diff failure for SqlSingleTest #84631

Closed
tannergooding opened this issue Apr 11, 2023 · 11 comments
Closed

SPMI diff failure for SqlSingleTest #84631

tannergooding opened this issue Apr 11, 2023 · 11 comments
Assignees
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@tannergooding
Copy link
Member

tannergooding commented Apr 11, 2023

Error Blob

{
  "ErrorMessage": "Assertion failed 'type != TYP_VOID' in 'System.Data.Tests.SqlTypes.SqlSingleTest:Lessers():this' during 'Expand static init'",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Reproduction Steps

No response

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@tannergooding tannergooding added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 11, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 11, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Apr 11, 2023
@ghost
Copy link

ghost commented Apr 11, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch, @kunalspathak
See info in area-owners.md if you want to be subscribed.

Issue Details

Error Blob

{
  "ErrorMessage": "Assertion failed 'type != TYP_VOID' in 'System.Data.Tests.SqlTypes.SqlSingleTest:Lessers():this' during 'Expand static init'",
  "BuildRetry": false,
  "ErrorPattern": "",
  "ExcludeConsoleLog": false
}

Reproduction Steps

No response

Author: tannergooding
Assignees: -
Labels:

area-CodeGen-coreclr, blocking-clean-ci, Known Build Error

Milestone: -

@EgorBo EgorBo self-assigned this Apr 11, 2023
@EgorBo EgorBo added this to the 8.0.0 milestone Apr 11, 2023
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Apr 11, 2023
@EgorBo
Copy link
Member

EgorBo commented Apr 11, 2023

the assert is fired in gtSplitTree

@EgorBo
Copy link
Member

EgorBo commented Apr 11, 2023

image

@jakobbotsch does it ring a bell to you why gtSplitTree fail here on void COMMA while splitting this tree on the helper call point?

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Apr 11, 2023
@jakobbotsch
Copy link
Member

@EgorBo The IR looks invalid, the type of a COMMA should always be the same as its op2. Where do we create that comma?

@EgorBo
Copy link
Member

EgorBo commented Apr 11, 2023

Where do we create that comma?

@SingleAccretion said it's dead store removal?

@BruceForstall
Copy link
Member

How did this regress, given that JIT PRs run replay/asmdiffs pipelines before checkin?

@jakobbotsch
Copy link
Member

@BruceForstall The PR that introduced the "Expand static init" phase (#83911) also changed JIT-EE GUID. The failure is in libraries tests so maybe the PR runs of libraries tests did not manage to expose it (another reason why it's good to trigger libraries-jitstress on large changes).

@BruceForstall
Copy link
Member

But spmi collection process would filter out any failures, so if #83911 introduced the failure but also changed the GUID, I would expect the new collection to hit the assertion during collection, but the collection "clean" process to remove the failing MCs from the resultant MCH.

@jakobbotsch
Copy link
Member

jakobbotsch commented Apr 11, 2023

Good point. On a closer look the issue actually was introduced with my change in the splitter in #83388 (itself a fix for a different issue I hit as part of that PR)... The last test runs in that PR were from Friday, so before the new phase.

@tannergooding
Copy link
Member Author

So this was the result of a couple different passing PRs conflicting post merge?

@jakobbotsch
Copy link
Member

Yes, essentially. Well, the bug was in my PR, but apparently stress did not manage to expose it until the extra cases seen with #83911.

@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Apr 11, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

No branches or pull requests

4 participants