Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[browser] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests fails with out of memory #101436

Closed
ilonatommy opened this issue Apr 23, 2024 · 8 comments
Labels
arch-wasm WebAssembly architecture area-System.Buffers area-VM-threading-mono Known Build Error Use this to report build issues in the .NET Helix tab os-browser Browser variant of arch-wasm
Milestone

Comments

@ilonatommy
Copy link
Member

ilonatommy commented Apr 23, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=653237
Build error leg or test failing: System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths
Pull request: #101390

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": [ "[FAIL] System.Buffers.ArrayPool", "System.OutOfMemoryException : Out of memory" ],
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Observed on 'WasmTestOnChrome-System.Buffers.Tests

[13:07:44] info: [FAIL] System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(requestedMinimum: 2097152, expectedLength: 2097152)
[13:07:44] info: System.OutOfMemoryException : Out of memory
[13:07:44] info:    at System.Buffers.ConfigurableArrayPool`1[[System.String, System.Private.CoreLib, Version=9.0.0.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e]].Rent(Int32 minimumLength)
[13:07:44] info:    at System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Int32 requestedMinimum, Int32 expectedLength)
[13:07:44] info:    at System.Object.InvokeStub_ArrayPoolUnitTests.RentingSpecificLengthsYieldsExpectedLengths(Object , Span`1 )
[13:07:44] info:    at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
[13:07:44] info: System.Buffers.ArrayPool.Tests.ArrayPoolUnitTests 17.1077205 ms

log

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=653237
Error message validated: [[FAIL] System.Buffers.ArrayPool System.OutOfMemoryException : Out of memory]
Result validation: ❌ Known issue did not match with the provided build.
Validation performed at: 4/25/2024 7:55:51 PM UTC

Report

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 0 0
@ilonatommy ilonatommy added arch-wasm WebAssembly architecture blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 23, 2024
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 23, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-buffers
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member

lewing commented Apr 24, 2024

The pattern is too broad and it is catching failures in System.Text.Json not ArrayPool tests. I'm going to close the issue, feel free to update the pattern to match the ArrayPool tests

@lewing lewing closed this as completed Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Apr 24, 2024
@lewing
Copy link
Member

lewing commented Apr 25, 2024

Updating the condition and reopening

@lewing lewing reopened this Apr 25, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 25, 2024
@lewing lewing removed the blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' label May 2, 2024
@lewing lewing added this to the 9.0.0 milestone May 2, 2024
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label May 2, 2024
@lewing
Copy link
Member

lewing commented May 3, 2024

@kg here are some common arraypool failures

@lewing
Copy link
Member

lewing commented May 3, 2024

Also worth reading #853

@pavelsavara
Copy link
Member

This is great log

[11:40:08] info: System.Buffers.ArrayPool.Tests.CollectionTests 0 ms
[11:40:08] fail: [0x012251a0-dpty 11:40:08.951] [MONO] Could not allocate 131072 (1 * 131072) bytes
                 Error
                     at tu (http://127.0.0.1:40487/_framework/dotnet.runtime.js:3:199931)
                     at wasm_trace_logger (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[197]:0x155ad)
                     at eglib_log_adapter (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[697]:0x4e9fc)
                     at monoeg_g_logv_nofree (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[615]:0x4c119)
                     at monoeg_g_log (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[617]:0x4c1dc)
                     at monoeg_g_calloc (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[607]:0x4bf7c)
                     at monoeg_malloc0 (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[608]:0x4bf96)
                     at rehash_table (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[2198]:0xbd6b5)
                     at mono_conc_hashtable_insert (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[2199]:0xbd81d)
                     at mono_metadata_lookup_generic_class (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[2455]:0xd146e)
                     at inflate_generic_type (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[1235]:0x7313a)
                     at mono_class_inflate_generic_type_with_mempool (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[1234]:0x72a72)
                     at mono_class_inflate_generic_class_checked (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[1237]:0x73253)
                     at mono_class_get_and_inflate_typespec_checked (http://127.0.0.1:40487/_framework/dotnet.native.wasm:wasm-function[1293]:0x7533e)

I guess other places don't produce as nice message when they can't allocate

@pavelsavara
Copy link
Member

no hits anymore

@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Buffers area-VM-threading-mono Known Build Error Use this to report build issues in the .NET Helix tab os-browser Browser variant of arch-wasm
Projects
None yet
Development

No branches or pull requests

3 participants