Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] consolidate merge of Microsoft.Maui.Graphics #747

Open
lytico opened this issue Apr 15, 2021 · 4 comments
Open

[Enhancement] consolidate merge of Microsoft.Maui.Graphics #747

lytico opened this issue Apr 15, 2021 · 4 comments
Assignees
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing t/enhancement ☀️ New feature or request
Milestone

Comments

@lytico
Copy link
Contributor

lytico commented Apr 15, 2021

Description

There are duplicates cause of Microsoft.Maui.Graphics

The apis should be consolidated

Duplicates

Maui Maui.Graphics
FontAttributes FontStyleType
TextAlignment VerticalAlignment
PenLineCap LineCap
PenLineJoin LineJoin
Matrix AffineTransform

functional overlappings

should be merged in some way: inheritance, members ...

Maui Maui.Graphics
Font IFontFamily
Font IFontStyle
IFontManager, eg. IFontService
@Eilon Eilon added the area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing label Oct 12, 2021
@jsuarezruiz jsuarezruiz added the t/enhancement ☀️ New feature or request label Oct 26, 2021
@Redth
Copy link
Member

Redth commented Nov 15, 2021

  • Move PenLineCap from Maui to replace LineCap in Maui.Graphics
  • Move PenLineJoin from Maui to replace LineJoin in Maui.Graphics
  • Move TextAlignment from Maui to replace VerticalAlignment in Maui.Graphics
  • AffineTransform is now using System.Numerics types - no action needed

@jsuarezruiz jsuarezruiz self-assigned this Nov 15, 2021
@jsuarezruiz
Copy link
Contributor

dotnet/Microsoft.Maui.Graphics#233

@AmrAlSayed0
Copy link
Contributor

Core-net6.csproj#L21 How will Maui.Graphics use Maui.Core? 😅 It will create a circular dependency.

@Redth Redth modified the milestones: 6.0.101-preview.10, .NET 7 Jan 27, 2022
@Redth Redth modified the milestones: .NET 7 + Servicing, Backlog Aug 29, 2022
@ghost
Copy link

ghost commented Aug 29, 2022

We've moved this issue to the Backlog milestone. This means that it is not going to be worked on for the coming release. We will reassess the backlog following the current release and consider this item at that time. To learn more about our issue management process and to have better expectation regarding different types of issues you can read our Triage Process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing t/enhancement ☀️ New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants