Make sure extensions libraries are marked <IsAotCompatible>true</IsAotCompatible>

[davidfowl]

While trying to use the Http resilisnce library auth PublishAot I got warnings:

EnableReloads

ILC : Trim analysis warning IL2091: Microsoft.Extensions.Http.Resilience.ResilienceHandlerContext.EnableReloads<TOptions>(String): 'TOptions' generic argument does not satisfy 'DynamicallyAccessedMemberTypes.PublicParameterlessConstructor' in 'Polly.DependencyInjection
.AddResiliencePipelineContext`1.EnableReloads<TOptions>(String)'. The generic parameter 'TOptions' of 'Microsoft.Extensions.Http.Resilience.ResilienceHandlerContext.EnableReloads<TOptions>(String)' does not have matching annotations. The source value must declare at le
ast the same requirements as those declared on the target location it is assigned to. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Polly.Timeout.TimeoutStrategyOptions.Timeout: Using member 'System.ComponentModel.DataAnnotations.RangeAttribute.RangeAttribute(Type,String,String)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming
application code. Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMembers All. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Polly.Timeout.TimeoutStrategyOptions.Timeout: Using member 'System.ComponentModel.DataAnnotations.RangeAttribute.RangeAttribute(Type,String,String)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming
application code. Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMembers All. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Microsoft.Extensions.Http.Resilience.Internal.Validators.HttpStandardResilienceOptionsValidator.Validate(String,HttpStandardResilienceOptions): Using member 'System.ComponentModel.DataAnnotations.ValidationContext.ValidationContext(O
bject)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The Type of instance cannot be statically discovered and the Type's properties can be trimmed. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.Backgrou
ndTasks.csproj]

Options Validation cc @tarekgh ?

ILC : Trim analysis warning IL2026: __OptionValidationStaticInstances.<Validators_g>F8B1F3D42962A35D8FF1B1489612AEF6C36F3713335EFF79DB68A25973333C495____Attributes..cctor(): Using member 'System.ComponentModel.DataAnnotations.LengthAttribute.LengthAttribute(Int32,Int32
)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Uses reflection to get the 'Count' property on types that don't implement ICollection. This 'Count' property may be trimmed. Ensure it is preserved. [C:\dev\git\eSh
op\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: __OptionValidationStaticInstances.<Validators_g>F8B1F3D42962A35D8FF1B1489612AEF6C36F3713335EFF79DB68A25973333C495____Attributes..cctor(): Using member 'System.ComponentModel.DataAnnotations.RangeAttribute.RangeAttribute(Type,String,S
tring)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMemb
ers All. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: __OptionValidationStaticInstances.<Validators_g>F8B1F3D42962A35D8FF1B1489612AEF6C36F3713335EFF79DB68A25973333C495____Attributes..cctor(): Using member 'System.ComponentModel.DataAnnotations.RangeAttribute.RangeAttribute(Type,String,S
tring)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMemb
ers All. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: __OptionValidationStaticInstances.<Validators_g>F8B1F3D42962A35D8FF1B1489612AEF6C36F3713335EFF79DB68A25973333C495____Attributes..cctor(): Using member 'System.ComponentModel.DataAnnotations.RangeAttribute.RangeAttribute(Type,String,S
tring)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. Generic TypeConverters may require the generic types to be annotated. For example, NullableConverter requires the underlying type to be DynamicallyAccessedMemb
ers All. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Microsoft.Extensions.Http.Resilience.__HttpRateLimiterStrategyOptionsValidator__.Validate(String,HttpRateLimiterStrategyOptions): Using member 'System.ComponentModel.DataAnnotations.ValidationContext.ValidationContext(Object)' which
has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The Type of instance cannot be statically discovered and the Type's properties can be trimmed. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj
]
ILC : Trim analysis warning IL2026: Microsoft.Extensions.Http.Resilience.__HttpTimeoutStrategyOptionsValidator__.Validate(String,HttpTimeoutStrategyOptions): Using member 'System.ComponentModel.DataAnnotations.ValidationContext.ValidationContext(Object)' which has 'Req
uiresUnreferencedCodeAttribute' can break functionality when trimming application code. The Type of instance cannot be statically discovered and the Type's properties can be trimmed. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Microsoft.Extensions.Http.Resilience.__HttpRetryStrategyOptionsValidator__.Validate(String,HttpRetryStrategyOptions): Using member 'System.ComponentModel.DataAnnotations.ValidationContext.ValidationContext(Object)' which has 'Require
sUnreferencedCodeAttribute' can break functionality when trimming application code. The Type of instance cannot be statically discovered and the Type's properties can be trimmed. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.csproj]
ILC : Trim analysis warning IL2026: Microsoft.Extensions.Http.Resilience.__HttpCircuitBreakerStrategyOptionsValidator__.Validate(String,HttpCircuitBreakerStrategyOptions): Using member 'System.ComponentModel.DataAnnotations.ValidationContext.ValidationContext(Object)'
which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. The Type of instance cannot be statically discovered and the Type's properties can be trimmed. [C:\dev\git\eShop\src\Ordering.BackgroundTasks\Ordering.BackgroundTasks.
csproj]

We should do a pass and make sure that we avoid warnings to make sure its possible to use these libraries with NativeAOT.

[davidfowl]

cc @eerhardt

[davidfowl]

It seems like we need to at a minimum rebuild with this dotnet/runtime#93193 to get rid of the source gen warnings with options validation?

[tarekgh]

@davidfowl right. You need dotnet/runtime#93193 to get rid of the trimming warnings. Could you please give it a try and let me know if you still see any case?

[tarekgh]

I thought the extensions repo already picked recent version of the source gen. isn't the case?

[martincostello]

Was this intended to be fixed in 8.0.0? I'm seeing these warnings in an app using the 8.0.100 SDK and the 8.0.0 packages.

[dariusclay]

I think there is still work to be done per #4625

[eerhardt]

#4625 is targeting the dev branch, which is the "9.0" train. There are a handful of source generator bugs in dotnet/runtime that we need to get into an 8.0.x servicing build to unblock this work. Once that is done, I will port #4625 to main which will resolve these warnings for the "8" train. It may take a couple servicing releases to get them all addressed.

[eerhardt]

This was fixed with #4871.