Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL dependency calls stopped getting logged when we migrated our SQLClient from System.Data.SqlClient to Microsoft.Data.SqlClient #2716

Open
mishas2303 opened this issue Jul 25, 2024 · 1 comment
Labels
⏳ Waiting for Customer Issues/PRs waiting for user response/action.

Comments

@mishas2303
Copy link

mishas2303 commented Jul 25, 2024

Describe the bug

We recently migrated our sdk from System.Data.SqlClient to Microsoft.Data.SqlClient - version="5.2.0"
and EF framework - Microsoft.EntityFramework.SqlServer" version="6.5.0-preview2-24180-01

And since then SQL Dependency calls have completely stopped since the date we upgraded to Microsoft.Data.SqlClient.

To reproduce

Attached the solution. For instrumentation key/sql connection connection string, feel free to ping me. I am an MS employee
TestSQLDependencyLogging.zip

Expected behavior

SQL dependency should be logged

These are the App Insights versions we're using which we didn't change
"Microsoft.ApplicationInsights" version="2.9.1
"Microsoft.ApplicationInsights.Agent.Intercept" version="2.4.0"
"Microsoft.ApplicationInsights.DependencyCollector" version="2.9.1"
"Microsoft.ApplicationInsights.PerfCounterCollector" version="2.9.1"
"Microsoft.ApplicationInsights.Web" version="2.9.1"
"Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel" version="2.9.1"
Microsoft.ApplicationInsights.WindowsServer" version="2.9.1"

Is there any additional config or ApplicationInsights version update that we need to do?

@ErikEJ
Copy link
Contributor

ErikEJ commented Jul 26, 2024

Your application insights dependency predates Microsoft.Data.SqlClient, so you really need to update to latest

@JRahnama JRahnama added the 🆕 Triage Needed For new issues, not triaged yet. label Jul 29, 2024
@kf-gonzalez2 kf-gonzalez2 added ⏳ Waiting for Customer Issues/PRs waiting for user response/action. and removed 🆕 Triage Needed For new issues, not triaged yet. labels Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏳ Waiting for Customer Issues/PRs waiting for user response/action.
Projects
Status: Needs More Info
Development

No branches or pull requests

4 participants