Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise closes connection too soon #381

Open
romainreuillon opened this issue Apr 23, 2024 · 0 comments
Open

Promise closes connection too soon #381

romainreuillon opened this issue Apr 23, 2024 · 0 comments

Comments

@romainreuillon
Copy link

romainreuillon commented Apr 23, 2024

Dear devs,

from what I can observe it seems that the exec function is not working when no mayBeClose promise is passed. i.e. I get nothing in the stdout sink and when I pass a mayBeClose I get some output.

I am not familiar with the skuber code yet, but it seems that this code make the close append right away:

val close = maybeClose.getOrElse(Promise.successful(()))

It is the case?

If yes, it would be the root cause of this bug

Best,
Romain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant