Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I miss you CleanLinks #172

Open
jawz101 opened this issue Aug 4, 2017 · 11 comments
Open

I miss you CleanLinks #172

jawz101 opened this issue Aug 4, 2017 · 11 comments

Comments

@jawz101
Copy link

jawz101 commented Aug 4, 2017

sad face

@jawz101 jawz101 closed this as completed Aug 13, 2017
@diegocr
Copy link
Owner

diegocr commented Aug 13, 2017

I miss it too ;)

Let's have a look at it when WebExtensions are formally established on stable releases of Firefox.

@jawz101
Copy link
Author

jawz101 commented Aug 14, 2017

Have you kept up with the nightlies?

I decided to go ahead and try it when they brought in layout.css.servo.enabled option (blazing fast.) And then 2 days ago they set extensions.legacy.enabled defaulting to false - which disabled even hybrid extensions. Suddenly AMO has maybe a hundred or so add-ons that are pure web extensions will install. NoScript, Lastpass, and Decentraleyes all moved into a disabled bucket on my browser.

And then yesterday my nightly icon was this. Today it was this. I think they are hinting we better board the hype train.

Giorgio was also interviewed on his NoScript work. I get the feeling they feel their current API's are solidified for v57 and now they're hoping people will start prepping for November.

My worry is for add-ons that might not go through the motions by then might have longer delays if they rely on extension API's that haven't been accounted for yet. Seems like you have to put in Bugzilla posts to get someone to consider reintroducing API's to allow for particular things. Like, some people had add-ons which tweaked about:config prefs so now there's a bugzilla issue out there to see about exposing a subset of prefs to be able to be manipulated by an add-on.

Basically, I don't know if you'll lose functionality to do what you did and, if so, would you ignore that piece or submit a request to have a solution re-added? Because that might mean an even longer wait or less priority by Mozilla devs than someone who prepped before then. I dunno.

@diegocr
Copy link
Owner

diegocr commented Aug 14, 2017

Actually, I have been using Nightly builds since ages ago, until a week or two ago that after an upgrade it refuses to start any longer, literally opening dozens of dialogs telling me that my profile is corrupt or such... even using a fresh profile gives the same behavior, which did remind me to some Windows 95 virus that was doing the same...i have to kill it from the TaskMan 🙄

Not sure what to think about the icons changing like that... well, the last one as you may know is the former Mozilla Firebird one (Firefox < 1.0)

As for your worries, the main CleanLinks algorithm can be (re-)implemented with vanilla JS and support for DOMContentLoaded or click listeners on the html document, no trouble doing that within a WebExtension i think, we may lose some functionality from advanced features such as http-observer, but at least a light version should be fast to implement...or so i hope.

@jawz101
Copy link
Author

jawz101 commented Aug 14, 2017

I never quite understood what the http observer was ... even though I activated it anyways.

I think I'm going back to stable, regardless. I'd rather the few add-ons that were hybrid still work for now. It's nice to see what nightly has going on but it feels like a war zone of half-baked ideas that may or may not move to stable. Kinda frustrating.

@alekksander
Copy link

alekksander commented Oct 26, 2017

please re-open. this thread contains important information from the author.

edit:
thank You

@jawz101 jawz101 reopened this Oct 26, 2017
@alekksander
Copy link

@diegocr any thoughts after v.57 has landed?

@YourFin
Copy link

YourFin commented Nov 15, 2017

I'd be happy to help port if it's needed

Repository owner deleted a comment from ImSpecial Nov 17, 2017
@jawz101
Copy link
Author

jawz101 commented Nov 29, 2017

@diegocr push it.

@diegocr
Copy link
Owner

diegocr commented Nov 29, 2017

@jawz101 yup..i know ;)

@jawz101
Copy link
Author

jawz101 commented Nov 30, 2017

@diegocr I like your taste lol
I can never understand what he's saying in the 1st sentence. I guess it's about places in Russia. Moskva = Moscow and some place called Gorky Park.

@jawz101
Copy link
Author

jawz101 commented May 1, 2018

any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants