Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaks the Disqus menu on comment area #143

Open
forteller opened this issue Aug 21, 2016 · 3 comments
Open

Breaks the Disqus menu on comment area #143

forteller opened this issue Aug 21, 2016 · 3 comments

Comments

@forteller
Copy link

Thank you very much for this great extension!

With CleanLinks 2.7.1-signed.1-signed turned on in my Firefox 48 it is impossible to open this menu on websites that use the Disqus comment system:

screenshot from 2016-08-21 16-35-04

Which means you can't log in. The link and the addressbar blinks yellow at the same time, and then the website is reloaded. Tested on omgubuntu.co.uk.

Hope this helps make CL even better! :)

@geokis
Copy link

geokis commented Aug 22, 2016

It is working without issue for me.


cl disqus


Enter this on the Skip domain textfield : disqus.com/embed,disqus.com,

@forteller
Copy link
Author

That worked for me too. I guess those two should be added as defaults?

@geokis
Copy link

geokis commented Aug 23, 2016

@forteller

I guess those two should be added as defaults?

It would be useful, otherwise Disqus doesn't works. But this is a decision that must be made by @diegocr

Btw. the whitelist contains some sites that not really necessary. E.G. plus.google.com never noticed any problem with the site and CL.
If you have some issue with the YouTube embedded Player enter youtube.com/embed, in the whitelist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants