Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LevelCelView: Changing height of tiles should be foolproof #135

Open
tetektoza opened this issue Nov 29, 2023 · 1 comment
Open

LevelCelView: Changing height of tiles should be foolproof #135

tetektoza opened this issue Nov 29, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@tetektoza
Copy link
Contributor

tetektoza commented Nov 29, 2023

Currently in LevelCelView, if we load level tiles to the GUI, we can set height of a tile, but if user feeds the line edit with any random number - it will take it, potentially freezing the app and making user to lose the progress.

My idea was to clip the value if it exceeds certain limit of height, for example 1000.

Talking specifically about this functionality:
image

@AJenbo
Copy link
Member

AJenbo commented Nov 30, 2023

11 would cover the screen height so probably just cap it at 10, or there a bout. Roughly 112 would cover the entire height of the level. I'm not even sure the engine will honor values over 8

@AJenbo AJenbo added the good first issue Good for newcomers label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants