-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sample :: _ -> _ -> Crossings producing incorrect result #337
Comments
One problem is that [p] = pathTrails $ B.union Winding (square 2)
crossingYIsMinus1 = trailCrossings (p2 (-2, -1)) p
crossingYIsPlus1 = trailCrossings (p2 (-2, 1)) p crossingYIsMinus1 now produces the expected result, but crossingYIsPlus1 still does not. edit: The param is also compared to 0 or 1 in signFromDerivAt. Loosening those comparisons fixes the example, but might possibly break other things. It requires further consideration. |
This is an attempted fix for issue diagrams#337. While it gets rid of some instances where test falsely returns a zero value, it is possible it may introduce some instances where test falsely returns a non-zero value.
l1/r1 are equivalent to l0/r0 except the straight segments get converted to cubic segments by B.union. They draw and fill correctly, so I think it's a problem with (sample :: _ -> _ -> Crossings) rather than a problem with B.union.
The text was updated successfully, but these errors were encountered: