Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css] Tables render without padding/margin #67

Open
bong0 opened this issue Aug 3, 2015 · 7 comments
Open

[css] Tables render without padding/margin #67

bong0 opened this issue Aug 3, 2015 · 7 comments

Comments

@bong0
Copy link

bong0 commented Aug 3, 2015

As in this screenshot from a wiki running the master.zip from 8f32c0b the table css leads to bad/unreadable rendering of table cells.
table source and rendered html

What would be the effort to change this to something like in mdwiki?

@bong0 bong0 changed the title [css] Tables render without padding [css] Tables render without padding/margin Aug 3, 2015
@asbjornu
Copy link

asbjornu commented Sep 7, 2015

I assume what's missing is class="table" on the <table> element.

@praveenscience
Copy link
Contributor

I am not sure if we can make Markdown to add extra classes, but we can redefine table {} in CSS right. :)

@asbjornu
Copy link

asbjornu commented Mar 4, 2016

If we control the Markdown to HTML conversion pipeline or can extend it somehow, we can add class="table" to all <table> elements, no? That's what would be required to have the Bootstrap style added to it.

@praveenscience
Copy link
Contributor

Won't that be against the implementation of original markdown parser? Also also I believe you can add extra features with GFM. I am gonna implement that soon.

@bong0
Copy link
Author

bong0 commented Mar 5, 2016

FYI: I'm not evaluating wikitten anymore but switched to a dokuwiki based solution. It has pretty nice markdown support and also one fairly good bootstrap theme.

@asbjornu
Copy link

asbjornu commented Mar 7, 2016

@praveenscience The parser shouldn't be involved in this at all. Adding class="table" would be done in the rendering of whatever the parser creates (an AST, I assume) from the Markdown markup. If it's possible to add a plugin to the rendering pipeline, that would be an elegant and simple solution.

@praveenscience
Copy link
Contributor

@asbjornu Agreed. There's a plan of using Parsedown instead of the original markdown, so this opens up to so many possibilities. I will try to check with the PD guys, if there's a possibility of adding extra class. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants