Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio: Definitions don't update in hover panels when the definitions file is updated. #79

Open
chrissimon-au opened this issue Jul 31, 2024 · 1 comment
Labels
bug Something isn't working VisualStudio

Comments

@chrissimon-au
Copy link
Contributor

Describe the bug
In most IDEs when editing the defintions file, the updated definitions appear in the hover panel immediately. In Visual Studio, they don't. This is because Visual Studio supports didChangeWatchedFile notifications, but it doesn't support dynamic registration, which is an approach where the language server can nominate which files to watch. See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#didChangeWatchedFilesRegistrationOptions for details.

To Reproduce
Open a folder with a .contextive/definitions.yml file, in Visual Studio with Contextive installed. See the hover panel text. Modify a term definition. Hover to see the hover panel, and see the old definition.

Expected behavior
The hover panel should show the new definition.

Additional context
According to the initialize logs, the language client advertises support for didChangeWatchedFiles with an empty object, which means it doesn't offer dynamic registration.

{
   ...
   "didChangeWatchedFiles": {}
   ...
}
@chrissimon-au
Copy link
Contributor Author

Tracked in Visual Studio Developer Community here

@chrissimon-au chrissimon-au added bug Something isn't working VisualStudio labels Jul 31, 2024
@chrissimon-au chrissimon-au changed the title Visual Studio: Definitions don't update in hover panels when the defintions file is updated. Visual Studio: Definitions don't update in hover panels when the definitions file is updated. Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VisualStudio
Projects
None yet
Development

No branches or pull requests

1 participant