Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual Studio: Shutdown Sequence leaves orphan language server processes #77

Open
chrissimon-au opened this issue Jul 31, 2024 · 1 comment
Labels
bug Something isn't working VisualStudio

Comments

@chrissimon-au
Copy link
Contributor

Describe the bug
After closing visual Studio, there are intermittently orphan Contextive.LanguageServer.exe processes

To Reproduce
Start Visual Studio with contextive installed and open a folder with a definitions file in .contextive/definitions.yml open a file and see a hover response (to confirm extension is working). Close Visual Studio.

Check task manager and see a Contextive.LanguageServer.exe process

Expected behavior
After existing visual Studio, there should be no Contextive.LanguageServer.exe process

Desktop (please complete the following information):

  • OS: Windows

Additional context
The LSP protocol defines that clients should send a shutdown request and wait for a response, which allows the language server to clean up resources. On successful response, they should send an exit notification and allow the language server to exit itself (ideally with process exit code 0). See https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#shutdown

From logs collected by @FH-Inway, we don't see any shutdown or exit messages, just a textDocument/didClose and then immediately Could not write to output handler, perhaps serialization failed? - which suggests the output pipe is disconnected - but the language server stays running.

@chrissimon-au chrissimon-au added the bug Something isn't working label Jul 31, 2024
@chrissimon-au
Copy link
Contributor Author

@FH-Inway - Visual Studio Developer Community requests that bugs are submitted using the Report a problem... feature in Visual Studio - see https://developercommunity.visualstudio.com/VisualStudio/report. As you have a running setup in VS, could you report via that method so that they can collect appropriate diagnostics.?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VisualStudio
Projects
None yet
Development

No branches or pull requests

1 participant