Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMG tags break Internet Explorer 11 #496

Closed
rasteiner opened this issue Apr 3, 2015 · 3 comments · May be fixed by derbyjs/tracks#23
Closed

IMG tags break Internet Explorer 11 #496

rasteiner opened this issue Apr 3, 2015 · 3 comments · May be fixed by derbyjs/tracks#23

Comments

@rasteiner
Copy link

In Internet Explorer 11 (didn't try the older ones), clicking on any image that has a src which starts with /, behaves like there is a link on the image, pointing to the image.

Reproduce:

git clone https://github.com/rasteiner/iekittentest
cd iekittentest
npm i
npm start

open http://localhost:3000 in IE11, click on the kitten and look at the address bar.

The test app is nothing more than a "yo derby:mini" with a kitten.jpg and an img tag.

PS: I've noticed that an external image file (eg: http://lorempixel.com/100/100) works correctly.
PPS: I have no clue where this is coming from, so I'm posting this here, since it's seems like a rather severe issue.
@rasteiner
Copy link
Author

The cause might be that IE puts a "href" property on img dom nodes. This line here seems suspicious: https://github.com/derbyjs/tracks/blob/master/lib/History.js#L156

rasteiner added a commit to rasteiner/tracks that referenced this issue Apr 3, 2015
@rasteiner
Should not treat images like links in Internet Explorer. fixes: derby…
ddfc5b8 
…js/derby#496
@rasteiner rasteiner mentioned this issue Apr 3, 2015
Open
@rasteiner
Copy link
Author

This isn't just me using the framework wrong. This is the framework having a rather serious bug in one of the main browsers.

One of the "derby used in production" sites:
http://gameofbombs.com/community/topic/669dd3f3-3d89-421a-b8cb-b6a13f9f0a91?page=1
click on any avatar image in IE11.

This also makes it essentially impossible to put an image into a link, since the "imaginary link"s click event fires first and doesn't even bubble to the "real link".

@rasteiner rasteiner reopened this Apr 8, 2015
@craigbeck
Copy link
Contributor

Thanks for your contributing your issue.

We have recently been actively updating the Derby and Racer packages, and both repos are now in Typescript and published with types on npm. As we have quite a few old issues open we have made the decision to close out of date issues.

If this issue still matters to you we encourage reproducing against the current versions of the repo and opening a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Should not treat images like links in Internet Explorer. rasteiner/tracks
2 participants
@craigbeck @rasteiner