Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review use of MEM_S8 #51

Open
EllipticEllipsis opened this issue May 8, 2023 · 0 comments
Open

Review use of MEM_S8 #51

EllipticEllipsis opened this issue May 8, 2023 · 0 comments

Comments

@EllipticEllipsis
Copy link
Contributor

Since char is unsigned in IDO, and we compile with char as unsigned, it seems unlikely that s8 is the correct type to use most of the time. There are currently 60 uses in libc_impl, in many different functions, so it's likely worth looking through them carefully rather than just replacing it away.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@EllipticEllipsis