From 6563414c6e9efaef9da664759981271aec899275 Mon Sep 17 00:00:00 2001
From: James O'Claire <jamesoclaire@gmail.com>
Date: Tue, 29 Oct 2024 08:50:50 +0800
Subject: [PATCH] Breadcrumbs fix!

---
 frontend/src/lib/Breadcrumbs.svelte | 18 ++++++------------
 1 file changed, 6 insertions(+), 12 deletions(-)

diff --git a/frontend/src/lib/Breadcrumbs.svelte b/frontend/src/lib/Breadcrumbs.svelte
index ed40bfc..88ea18d 100644
--- a/frontend/src/lib/Breadcrumbs.svelte
+++ b/frontend/src/lib/Breadcrumbs.svelte
@@ -1,6 +1,4 @@
 <script lang="ts" generics="Metadata = any">
-	import { run } from 'svelte/legacy';
-
 	import type { Crumb, ModuleData } from '.././types';
 	import { onMount } from 'svelte';
 
@@ -51,11 +49,11 @@
 	}
 
 	let _crumbs = $state([] as Crumb<Metadata>[]);
-	run(() => {
-		_crumbs = [] as Crumb<Metadata>[];
+	$effect(() => {
+		let tmpCrumbs = [] as Crumb<Metadata>[];
 		if (crumbs != undefined) {
 			// If crumbs array is passed in always use that with highest priority
-			_crumbs = [...crumbs];
+			tmpCrumbs = [...crumbs];
 		} else if (routeId) {
 			// If there is routeing info, use it to find the page modules and
 			// subsequently the page titles for each route leading up to the
@@ -88,15 +86,12 @@
 				const routeModule =
 					routeModules === undefined ? undefined : routeModules[`${completeRoute}+page.svelte`];
 
-				_crumbs.push({
+				tmpCrumbs.push({
 					// Last crumb gets no url as it is the current page
 					url: i == paths.length - 1 ? undefined : completeUrl,
 					title: getPageTitleFromModule(routeModule) || titleSanitizer(path)
 				});
 			}
-
-			// Force trigger an update
-			_crumbs = _crumbs;
 		} else {
 			// And if there is no route info, simply generate breadcrumbs from the url
 			// path
@@ -105,14 +100,13 @@
 			for (let i = 0; i < paths.length; i++) {
 				let path = paths[i];
 				completeUrl += `/${path}`;
-				_crumbs.push({
+				tmpCrumbs.push({
 					title: titleSanitizer(path),
 					url: i == paths.length - 1 ? undefined : completeUrl
 				});
 			}
-
-			_crumbs = _crumbs;
 		}
+		_crumbs = tmpCrumbs;
 	});
 </script>