Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL-2147] [Bug] You should be able to silence Pydantic warning for multiple identical input measures #1185

Open
2 tasks done
Jstein77 opened this issue May 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working Low priority Created by Linear-GitHub Sync Low Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged

Comments

@Jstein77
Copy link
Contributor

Jstein77 commented May 7, 2024

Is this a new bug in metricflow?

  • I believe this is a new bug in metricflow
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

I've been receiving the following message for multiple metrics when i parse my project. There aren't any errors in these metrics and they aren't duplicated.
17:09:30 PydanticMetric metrics_queried_l14d_wow_growth has multiple identical input measures specifications for measure metrics_queried. This might be hiding a semantic error. Input measure specification: name='metrics_queried' filter=None alias=None join_to_timespine=False fill_nulls_with=None.

Expected Behavior

I should be able to silence these warning, or we should provide a path to fix these warnings.

Steps To Reproduce

Create a metric with multiple identical input measures specifications and run dbt parse

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:
- metricflow:

Which database are you using?

No response

Additional Context

No response

SL-2147

@Jstein77 Jstein77 added bug Something isn't working triage Tasks that need to be triaged labels May 7, 2024
@Jstein77 Jstein77 changed the title [Bug] You should be able to silence Pydantic warning for multiple identical input measures [SL-2147] [Bug] You should be able to silence Pydantic warning for multiple identical input measures May 7, 2024
@Jstein77 Jstein77 added Medium priority Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync Low Created by Linear-GitHub Sync labels May 8, 2024
@siljamardla
Copy link

When can we expect this to be taken up? We are at the point of having 200+ metrics throw this warning on every parse, this is super confusing for our dbt users who are not power users and don't need to know what this warning means.

@Jstein77 Jstein77 added this to the v.21 milestone May 30, 2024
@Jstein77
Copy link
Contributor Author

@siljamardla we're gonna pick this up next week. It's been hanging around for too long.

@Jstein77 Jstein77 modified the milestones: v.21, v.22, v.23 Jun 3, 2024
@Jstein77 Jstein77 modified the milestones: v.23, v.24 Jun 17, 2024
@Jstein77 Jstein77 modified the milestones: v.24, v.25, v.26 Jun 24, 2024
@Jstein77 Jstein77 modified the milestones: v.26, v.27 Jul 8, 2024
@Jstein77 Jstein77 added Low priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Jul 11, 2024
@Jstein77 Jstein77 modified the milestones: v.27, v.28 Jul 15, 2024
@Jstein77 Jstein77 modified the milestones: v.28, v.29 Jul 22, 2024
@Jstein77 Jstein77 modified the milestones: v.29, v.30, v.31 Jul 29, 2024
@Jstein77 Jstein77 modified the milestones: v.31, v.32 Aug 12, 2024
@Jstein77 Jstein77 added this to the MetricFlow Sprint milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Low priority Created by Linear-GitHub Sync Low Created by Linear-GitHub Sync Metricflow Created by Linear-GitHub Sync triage Tasks that need to be triaged
Projects
None yet
Development

No branches or pull requests

4 participants