We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
date_spine
dbt-adapters
The date range within fixture_date_spine.py is larger than needed.
fixture_date_spine.py
This doesn't affect the correctness of the test, but it does affect it's readability.
The test would be more readable with a minimal date range.
History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.
The content you are editing has changed. Please copy your edits and refresh the page.
1999-12-31
2000-01-03
2024-02-28
2024-03-02
See acceptance criteria above.
No security concerns.
No doc updates needed.
This change impacts any adapter that imports this test. But it doesn't change the essence of the test and will effectively be a no-op.
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Housekeeping
dbt-adapters
Short description
The date range within
fixture_date_spine.py
is larger than needed.Context
This doesn't affect the correctness of the test, but it does affect it's readability.
The test would be more readable with a minimal date range.
History: this test was migrated effectively as-is from dbt-utils to dbt-core to dbt-adapters. But now we'll probably want to clean it up a bit.
Acceptance criteria
Tasks
Testing
See acceptance criteria above.
Security
No security concerns.
Docs
No doc updates needed.
Consequences
This change impacts any adapter that imports this test. But it doesn't change the essence of the test and will effectively be a no-op.
The text was updated successfully, but these errors were encountered: