-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dbilokha/viber #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viber 🚀
My granny will be so happy!!!
CONTAINER_VERSION: process.env.CONTAINER_VERSION, | ||
LOGGLY_TOKEN: process.env.LOGGLY_TOKEN, | ||
LOGGLY_SUBDOMAIN: process.env.LOGGLY_SUBDOMAIN ?? 'covid19liveupd', | ||
LOGGLY_TAGS: tags, | ||
APP_URL: process.env.APP_URL ?? '', | ||
NGROK_URL: process.env.APP_URL ?? '', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danbilokha Do we stop using NGROK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean for local development
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, but I think it is misleading property since it has to be APP_URL
import { Express } from 'express'; | ||
import * as Viber from 'viber-bot'; | ||
|
||
export async function runViberBot( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
API Looks super similar to telegram.
That's cool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's true. There are a lot things to improve, honestly. SOOOO MUCH TO MOVE TO ABSTRACT
); | ||
} | ||
|
||
checkCovid19Updates(); | ||
// tslint:disable-next-line:no-console | ||
console.log(`${CONSOLE_LOG_DELIMITER}Starting Telegram bot`); | ||
runTelegramBot(app, appUrl, environments.TELEGRAM_TOKEN); | ||
|
||
// tslint:disable-next-line:no-console | ||
console.log(`${CONSOLE_LOG_DELIMITER}Starting Viber bot`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danbilokha Do you mind adding feature flag here?
I'm not sure if it's really needed. But I'd like to have one, since it looks like we are going to launch. Our bot responder withing single app.
What is your opinion about that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Та забей....
# Conflicts: # server/src/locales/en.json # server/src/locales/ua.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My granny will be so happy to see it in viber finally.
God bless you @danbilokha
import { unsubscribeStrategyResponse } from './botResponse/unsubscribeResponse'; | ||
import { trendsByCountryResponse } from './botResponse/trendResponse'; | ||
import { CountrySituationInfo } from '../../models/covid19.models'; | ||
import { catchAsyncError } from '../../utils/catchError'; | ||
import { runSendScheduledNotificationToUsersJob } from '../../services/infrastructure/scheduler'; | ||
import { telegramUserService } from './services/user'; | ||
import { withSingleParameterAfterCommand } from './services/registry/withSingleParameterAfterCommand'; | ||
import { withSingleParameterAfterCommand } from '../../services/domain/registry/withSingleParameterAfterCommand'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@danbilokha does it really belongs to domain.
I mean I'm ok with that just curious about how you see it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's rather infrastructure, moving it there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oop, I am not sure ...
"Enter country name by a pattern": "Enter country name by a pattern", | ||
"[country name]": "[country name]", | ||
"Main menu": "Main menu", | ||
"Привіт, %s": "Привіт, %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Привіт, Welcome on board
No description provided.